accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request: Patch submitted by Chris McCubbin to add thrift proxy to Accumulo
Date Wed, 07 Nov 2012 21:44:54 GMT


> On Nov. 7, 2012, 9:41 p.m., kturner wrote:
> > /trunk/proxy/README, line 13
> > <https://reviews.apache.org/r/7936/diff/1/?file=186398#file186398line13>
> >
> >     May be useful to provide guidance on how proxies should be run in a cluster.
 For example run one proxy for each client node.
> >     
> >     So what should this guidance be?  Whats the best practice?
> >     
> >     Running a proxy process on every node where a client runs may be the most efficient.
 But if the user has to manage this it could be cumbersome.  We could help by having each
tserver run a proxy process may be the most convienet for users.  Could do this and provide
a little bit of code for each language that helps a user find proxy.   This utility could
prefer a local tserver if there is one and otherwise choose a random one.  Having tservers
run a proxy service may make them less stable.
> >

Just realized that running on a proxy on each tserver is probably a bad idea.  It make the
user of the thrift API have to handle failure cases (i.e. remote proxy I was using failed,
now I need to select another).   If you are running a local proxy process, there could be
failures but I think its much less likely.  Using a local proxy and letting the Accumulo client
code handle remote failures seems like a good way to go.


- kturner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7936/#review13224
-----------------------------------------------------------


On Nov. 7, 2012, 8:33 p.m., kturner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7936/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2012, 8:33 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Description
> -------
> 
> Patch submitted by Chris McCubbin to add thrift proxy to Accumulo
> 
> 
> This addresses bug ACCUMULO-482.
>     https://issues.apache.org/jira/browse/ACCUMULO-482
> 
> 
> Diffs
> -----
> 
>   /trunk/pom.xml 1406772 
>   /trunk/proxy/README PRE-CREATION 
>   /trunk/proxy/examples/python/README PRE-CREATION 
>   /trunk/proxy/examples/python/TestClient.py PRE-CREATION 
>   /trunk/proxy/examples/python/data/__init__.py PRE-CREATION 
>   /trunk/proxy/examples/python/data/constants.py PRE-CREATION 
>   /trunk/proxy/examples/python/data/ttypes.py PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/AccumuloProxy-remote PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/AccumuloProxy.py PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/__init__.py PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/constants.py PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/ttypes.py PRE-CREATION 
>   /trunk/proxy/examples/ruby/README PRE-CREATION 
>   /trunk/proxy/examples/ruby/accumulo_proxy.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/data_constants.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/data_types.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/proxy_constants.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/proxy_types.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/test_client.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/thrift.rb PRE-CREATION 
>   /trunk/proxy/pom.xml PRE-CREATION 
>   /trunk/proxy/proxy.properties PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyHarness.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/TestProxyClient.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/Util.java PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloException.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloProxy.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloSecurityException.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/IOException.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/KeyValueAndPeek.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/NoMoreEntriesException.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/ProxyIteratorSetting.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/ProxySystemPermission.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/ProxyTablePermission.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/TableExistsException.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/TableNotFoundException.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/UserPass.java PRE-CREATION

>   /trunk/proxy/src/main/thrift/data.thrift PRE-CREATION 
>   /trunk/proxy/src/main/thrift/proxy.thrift PRE-CREATION 
>   /trunk/proxy/src/test/java/org/apache/accumulo/TestProxyInstanceOperations.java PRE-CREATION

>   /trunk/proxy/src/test/java/org/apache/accumulo/TestProxyReadWrite.java PRE-CREATION

>   /trunk/proxy/src/test/java/org/apache/accumulo/TestProxySecurityOperations.java PRE-CREATION

>   /trunk/proxy/src/test/java/org/apache/accumulo/TestProxyTableOperations.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/7936/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> kturner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message