accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Tubbs <ctubb...@gmail.com>
Subject Re: ExportTable.isReady - alternative to for loop?
Date Thu, 06 Sep 2012 04:28:53 GMT
I've already patched that. It just hasn't been committed.
See: https://issues.apache.org/jira/browse/ACCUMULO-456
Patch: https://issues.apache.org/jira/secure/attachment/12543936/ACCUMULO-456-4.patch

On Wed, Sep 5, 2012 at 10:20 PM, David Medinets
<david.medinets@gmail.com> wrote:
> This is the code I am looking at:
>
>     // TODO look for walogs
>     for (Entry<Key,Value> entry : metaScanner) {
>       return 500;
>     }
>
>     return 0;
>
> FindBugs complains that entry is unused. Does it make sense to replace
> that code with:
>
>   return metaScanner.iterator().hasNext() ? 500 : 0;

Mime
View raw message