accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Newton <eric.new...@gmail.com>
Subject Re: Review Request: Add import/export table
Date Mon, 06 Aug 2012 16:23:56 GMT
ACCUMULO-717 and ACCUMULO-718.

-Eric

On Mon, Aug 6, 2012 at 10:21 AM, <keith@deenlo.com> wrote:

>
>
> > On Aug. 6, 2012, 1:08 p.m., Eric Newton wrote:
> > >
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java,
> line 197
> > > <
> https://reviews.apache.org/r/6138/diff/2/?file=131589#file131589line197>
> > >
> > >     Any reason why we don't have a a non-static version of
> ColumnFQ.fetch? We could simply write:
> > >
> > >     METADATA_PREV_ROW_COLUMN.fetch(metaScanner);
>
> I would prefer to do a change like that as part of another ticket and
> patch/commit.  Making that change would touch a lot of code unrelated to
> this ticket.  Concise patches are nice when reviewing code, merging, and
> investigating bugs.
>
>
> > On Aug. 6, 2012, 1:08 p.m., Eric Newton wrote:
> > >
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java,
> line 199
> > > <
> https://reviews.apache.org/r/6138/diff/2/?file=131590#file131590line199>
> > >
> > >     Let's make the Master's getConnector method public, so we can
> avoid calls to HdfsZooInstance.getInstance().
>
> This would also be a candidate for another ticket and patch.  If this were
> done, it would be best to do it for all FATE operations instead of just
> this new one.
>
>
> - kturner
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6138/#review9885
> -----------------------------------------------------------
>
>
> On July 31, 2012, 9:51 p.m., kturner wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/6138/
> > -----------------------------------------------------------
> >
> > (Updated July 31, 2012, 9:51 p.m.)
> >
> >
> > Review request for accumulo.
> >
> >
> > Description
> > -------
> >
> > A patch to add import and export table to Accumulo
> >
> >
> > This addresses bug ACCUMULO-456.
> >     https://issues.apache.org/jira/browse/ACCUMULO-456
> >
> >
> > Diffs
> > -----
> >
> >   /trunk/core/src/main/java/org/apache/accumulo/core/Constants.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java
> 1366092
> >   /trunk/core/src/main/java/org/apache/accumulo/core/conf/Property.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java
> PRE-CREATION
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java
> PRE-CREATION
> >   /trunk/core/src/main/thrift/client.thrift 1366092
> >   /trunk/core/src/main/thrift/master.thrift 1366092
> >
> /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java
> 1366092
> >   /trunk/docs/examples/README.export PRE-CREATION
> >   /trunk/docs/src/user_manual/chapters/table_configuration.tex 1366092
> >
> /trunk/server/src/main/java/org/apache/accumulo/server/master/Master.java
> 1366092
> >
> /trunk/server/src/main/java/org/apache/accumulo/server/master/state/tables/TableManager.java
> 1366092
> >
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java
> PRE-CREATION
> >
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java
> PRE-CREATION
> >
> /trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ExportIndex.java
> PRE-CREATION
> >   /trunk/test/system/randomwalk/conf/modules/Shard.xml 1366092
> >
> > Diff: https://reviews.apache.org/r/6138/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > kturner
> >
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message