accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Vines <vi...@apache.org>
Subject Re: Please review check-ins
Date Thu, 23 Aug 2012 13:27:39 GMT
They look kosher to me

On Thu, Aug 23, 2012 at 8:25 AM, Keith Turner <keith@deenlo.com> wrote:

> I will take a look at them.  If they did not have test, then you
> probably do not need to add test when making improvements like this.
> I would recommend at least executing the code though.  Many times I
> have made what I thought were simple changes and it blew up for some
> reason.
>
> On Thu, Aug 23, 2012 at 12:01 AM, David Medinets
> <david.medinets@gmail.com> wrote:
> > Both of the following jira tickets are related to unclosed objects.
> > The changes were fairly simply and the code compiled after my change.
> > I did not create any tests or execute the code. If someone can do a
> > review after a 'svn update', I'd appreciate it.
> >
> > https://issues.apache.org/jira/browse/ACCUMULO-737
> > https://issues.apache.org/jira/browse/ACCUMULO-738
> >
> > Thanks
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message