accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request: Quotes in visibility
Date Thu, 30 Aug 2012 23:13:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6861/#review10920
-----------------------------------------------------------



/trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java
<https://reviews.apache.org/r/6861/#comment23454>

    JavaDoc should be updated to reflect the new changes.



/trunk/core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java
<https://reviews.apache.org/r/6861/#comment23456>

    Can you add another test that checks quotes + parenthesis?



/trunk/core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java
<https://reviews.apache.org/r/6861/#comment23455>

    Catch VisibilityParseException?


- Mike Drob


On Aug. 30, 2012, 8:59 p.m., kturner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6861/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2012, 8:59 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Description
> -------
> 
> A patch for adding quoting to column visibility
> 
> 
> Diffs
> -----
> 
>   /trunk/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 1379035

>   /trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java 1379035

>   /trunk/core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java
1379035 
>   /trunk/core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java
1379035 
>   /trunk/core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java
1379035 
> 
> Diff: https://reviews.apache.org/r/6861/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> kturner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message