accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William Slacum (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-675) WrappingIterator's seenSeek should be protected
Date Sun, 22 Jul 2012 01:39:33 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420055#comment-13420055
] 

William Slacum commented on ACCUMULO-675:
-----------------------------------------

Looks good to me.
                
> WrappingIterator's seenSeek should be protected
> -----------------------------------------------
>
>                 Key: ACCUMULO-675
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-675
>             Project: Accumulo
>          Issue Type: Bug
>          Components: tserver
>    Affects Versions: 1.5.0, 1.4.1, 1.5.0-SNAPSHOT, 1.4.0
>         Environment: OSX, Linux
>            Reporter: William Slacum
>            Assignee: William Slacum
>            Priority: Trivial
>             Fix For: 1.5.0-SNAPSHOT
>
>         Attachments: wrapping-iterator-mod.patch
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> In 1.3, the WrappingIterator was pretty much some boilerplate code. In 1.4 on, a package
private boolean called seenSeek was added to help enforce the iterator contract.
> This causes some issues with iterators written for 1.3 and before, because the seenSeek
property can't be set by an iterator outside of the core.iterators package, which is locked
down. This means that sub iterators must always delegate up to the WrappingIterator's seek()
method, even if implementors want to completely override seek().
> I would like to provide more documentation on the WrappingIterator and make the seenSeek
property protected so implementors don't need conditional logic to make the call to super.seek().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message