Mailing-List: contact accumulo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: accumulo-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: local policy)
MIME-Version: 1.0
In-Reply-To: 
 <1616312124.224569.1332173642197.JavaMail.root@linzimmb04o.imo.intelink.gov>
References: 
 <CAGUtCHrP03GmP5ZTN=RWsJP7KGton3wG1oMdJFOE6SDLK6ywjA@mail.gmail.com>
 <1692225682.224237.1332170145385.JavaMail.root@linzimmb04o.imo.intelink.gov>
 <1616312124.224569.1332173642197.JavaMail.root@linzimmb04o.imo.intelink.gov>
From: John Vines <john.w.vines@ugov.gov>
Date: Mon, 19 Mar 2012 12:27:43 -0400
Message-ID: 
 <CADczPYSy_ET2sJvZm2_aFzfhpuy=WU_7N8ygCVndAFZn3WAVPA@mail.gmail.com>
Subject: Re: [VOTE] accumulo-1.4.0-incubating RC1
To: accumulo-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=20cf307f3bfeeddd0604bb9b0a96

--20cf307f3bfeeddd0604bb9b0a96
Content-Type: text/plain; charset=ISO-8859-1

The issue wasn't that RAT wasn't informing of errors, it was that it wasn't
running on the data correctly. This resulted in entire submodules being
missed. Additionally, in 1.4, we just have an expected list of failures we
check against. In trunk, I switched to using a new version of RAT with
better support for generated files. With that, I updated the excludes list
so that we should maintain 0 failures. However, it's been brought to my
attention with the shifting around of files, the excludes file is out of
date. I think if we were to run mvn rat:check, it would properly show
errors.

I think I have a standing ticket for a release profile which runs all of
the necessary items we need to run before a release, which would include a
rat:check.

John

On Mon, Mar 19, 2012 at 12:14 PM, Benson Margulies <bimargulies@gmail.com>wrote:

> Can we get rat to 'inform' on missing headers more aggressively?
>
> On Mon, Mar 19, 2012 at 11:15 AM, Billie J Rinaldi
> <billie.j.rinaldi@ugov.gov> wrote:
> > -1
> >
> > Signatures and checksums are ok.  I think the src tarball probably
> shouldn't have the .gitignore file in it, but I wouldn't consider that a
> blocker.
> >
> > These files in wikisearch ingest doesn't have license headers.  That's a
> blocker.
> >
> > org.apache.accumulo.examples.wikisearch.ingest.LRUOutputCombiner.java
> >
> org.apache.accumulo.examples.wikisearch.output.BufferingRFileRecordWriter.java
> org.apache.accumulo.examples.wikisearch.output.SortingRFileOutputFormat.java
> >
> org.apache.accumulo.examples.wikisearch.ingest.WikipediaInputSplitTest.java
> (test)
> >
> > There's also a jar in an unexpected place in the dist tarball:
> >
> > src/lib/examples-simple-1.4.0-incubating-sources.jar
> >
> > This jar is not identical to the one of the same name in lib.  I'm not
> sure if that's a blocker or not.
> >
> > Billie
> >
> >
> > ----- Original Message -----
> >> From: "Keith Turner" <keith@deenlo.com>
> >> To: accumulo-dev@incubator.apache.org
> >> Sent: Friday, March 16, 2012 2:11:19 PM
> >> Subject: Re: [VOTE] accumulo-1.4.0-incubating RC1
> >> Since the build.sh script in the source tar bar does not work I
> >> propose changing the vote request to the following :
> >>
> >> -----------
> >>
> >> Please vote on releasing the following candidate as Apache Accumulo
> >> (incubating) version 1.4.0.
> >>
> >> The src tar ball was generated by exporting :
> >> https://svn.apache.org/repos/asf/incubator/accumulo/tags/1.4.0rc1
> >>
> >> To build the dist tar ball from the source run the following commands
> >> :
> >> mvn package
> >> mvn package javadoc:aggregate javadoc:jar source:jar
> >> (cd src/server/src/main/c++; make)
> >> mvn assembly:single -N
> >>
> >> Tarballs, checksums, signatures:
> >> http://people.apache.org/~kturner/1.4.0rc1/
> >>
> >> Maven Staged Repository:
> >>
> https://repository.apache.org/content/repositories/orgapacheaccumulo-077
> >>
> >> SVN tag:
> >> https://svn.apache.org/repos/asf/incubator/accumulo/tags/1.4.0rc1/
> >>
> >> Keys:
> >> http://www.apache.org/dist/incubator/accumulo/KEYS
> >>
> >> Changes:
> >>
> https://svn.apache.org/repos/asf/incubator/accumulo/tags/1.4.0rc1/CHANGES
> >>
> >> The vote will be held open for the next 72 hours.
> >>
> >> On Wed, Mar 14, 2012 at 11:37 AM, Keith Turner <keith@deenlo.com>
> >> wrote:
> >> > Please vote on releasing the following candidate as Apache Accumulo
> >> > (incubating) version 1.4.0.
> >> >
> >> > I generated the tarballs by exporting
> >> > https://svn.apache.org/repos/asf/incubator/accumulo/tags/1.4.0rc1
> >> > then running "tar cvzf" to create the src and running
> >> > "./src/assemble/build.sh" to create the dist.
> >> >
> >> > Tarballs, checksums, signatures:
> >> >  http://people.apache.org/~kturner/1.4.0rc1/
> >> >
> >> > Maven Staged Repository:
> >> >
> https://repository.apache.org/content/repositories/orgapacheaccumulo-077
> >> >
> >> > SVN tag:
> >> >  https://svn.apache.org/repos/asf/incubator/accumulo/tags/1.4.0rc1/
> >> >
> >> > Keys:
> >> >  http://www.apache.org/dist/incubator/accumulo/KEYS
> >> >
> >> > Changes:
> >> >
> https://svn.apache.org/repos/asf/incubator/accumulo/tags/1.4.0rc1/CHANGES
> >> >
> >> > The vote will be held open for the next 72 hours.
> >> >
> >> > Thanks,
> >> > Keith
>

--20cf307f3bfeeddd0604bb9b0a96--