accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Medinets <david.medin...@gmail.com>
Subject How to handle FindBugs Issues?
Date Mon, 05 Mar 2012 04:45:47 GMT
Should I create a separate JIRA ticket for each issue that FindBugs
finds? Most of them will be trivial. Here is an example. In RFile.java
there is:

  public void printInfo() throws IOException {
    ...
    out.println("\tNum   blocks         : " + String.format("%,d",
indexReader.size()));
    ...
    if (indexReader != null && indexReader.size() > 0) {
      lastKey = indexReader.getLastKey();
    }
    ...
  }

Since the indexReader is already referenced, the null check is not
helpful in its current location. The resolution is simple but should a
few of these issues be rolled into one JIRA? Or a separate JIRA for
each one? Or no JIRA at all?

Mime
View raw message