accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Keith Turner <ke...@deenlo.com>
Subject Re: How to handle FindBugs Issues?
Date Mon, 05 Mar 2012 15:47:04 GMT
I think one ticket is good too.  One other option is to create a
ticket for each type of issue.  For example if there were 20 instances
of the same type of bug in hashCode() methods.  I assume that its
finding lots of different types of issues though, so in this case I
would go w/ one ticket.

On Mon, Mar 5, 2012 at 9:08 AM, John Vines <john.w.vines@ugov.gov> wrote:
> I would just create a generic ticket for cleaning up findbugs
> warnings/errors. Perhaps even just a generic ticket for fixing static code
> analyzer warnings/errors.
>
> John
>
> On Sun, Mar 4, 2012 at 11:46 PM, David Medinets <david.medinets@gmail.com>wrote:
>
>> Should I create a separate JIRA ticket for each issue that FindBugs
>> finds? Most of them will be trivial. Here is an example. In RFile.java
>> there is:
>>
>>  public void printInfo() throws IOException {
>>    ...
>>    out.println("\tNum   blocks         : " + String.format("%,d",
>> indexReader.size()));
>>    ...
>>    if (indexReader != null && indexReader.size() > 0) {
>>      lastKey = indexReader.getLastKey();
>>    }
>>    ...
>>  }
>>
>> Since the indexReader is already referenced, the null check is not
>> helpful in its current location. The resolution is simple but should a
>> few of these issues be rolled into one JIRA? Or a separate JIRA for
>> each one? Or no JIRA at all?
>>

Mime
View raw message