accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Vines <john.w.vi...@ugov.gov>
Subject Re: How to handle FindBugs Issues?
Date Mon, 05 Mar 2012 14:08:20 GMT
I would just create a generic ticket for cleaning up findbugs
warnings/errors. Perhaps even just a generic ticket for fixing static code
analyzer warnings/errors.

John

On Sun, Mar 4, 2012 at 11:46 PM, David Medinets <david.medinets@gmail.com>wrote:

> Should I create a separate JIRA ticket for each issue that FindBugs
> finds? Most of them will be trivial. Here is an example. In RFile.java
> there is:
>
>  public void printInfo() throws IOException {
>    ...
>    out.println("\tNum   blocks         : " + String.format("%,d",
> indexReader.size()));
>    ...
>    if (indexReader != null && indexReader.size() > 0) {
>      lastKey = indexReader.getLastKey();
>    }
>    ...
>  }
>
> Since the indexReader is already referenced, the null check is not
> helpful in its current location. The resolution is simple but should a
> few of these issues be rolled into one JIRA? Or a separate JIRA for
> each one? Or no JIRA at all?
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message