accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-149) Remove MyMapFile dependency in Isolation Image
Date Fri, 23 Dec 2011 20:16:30 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175567#comment-13175567
] 

Keith Turner commented on ACCUMULO-149:
---------------------------------------

John, I think the changes broke seeking backwards in the in memory map.  I was looking at
the MemKeyConversionIterator.consume() method and was thinking it could prevent seeking backwards.
 I wrote the following test to confirm this.  Add the following test to the InMemoryMapTest
and it will fail.

{noformat}
  public void testSeekBackWards() throws Exception {
    InMemoryMap imm = new InMemoryMap(false, "/tmp");
    
    mutate(imm, "r1", "foo:cq1", 3, "bar1");
    mutate(imm, "r1", "foo:cq2", 3, "bar2");
    mutate(imm, "r1", "foo:cq3", 3, "bar3");
    mutate(imm, "r1", "foo:cq4", 3, "bar4");
    
    MemoryIterator skvi1 = imm.skvIterator();
    
    skvi1.seek(new Range(nk("r1", "foo:cq3", 3), null), LocalityGroupUtil.EMPTY_CF_SET, false);
    ae(skvi1, "r1", "foo:cq3", 3, "bar3");
    
    skvi1.seek(new Range(nk("r1", "foo:cq1", 3), null), LocalityGroupUtil.EMPTY_CF_SET, false);
    ae(skvi1, "r1", "foo:cq1", 3, "bar1");

  }
{noformat}
                
> Remove MyMapFile dependency in Isolation Image
> ----------------------------------------------
>
>                 Key: ACCUMULO-149
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-149
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: tserver
>            Reporter: John Vines
>            Assignee: John Vines
>              Labels: cleanup
>             Fix For: 1.5.0
>
>
> MyMapFile and MySequenceFile are my mortal enemies and I wish for nothing more than to
purge them from our codebase. The biggest standing issue keeping us from removing them entirely
and using the compatible MapFile and SequenceFile is the isolation image we use to ensure
Scanner consistency. It writes a temp MyMapFile to scan against until all scanners for that
timeframe are complete. Because of the extra information stored in the file, an RFile is not
quite compatible. So we need to come up with a method to use RFile to get done what we need
to get done.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message