accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubb...@apache.org
Subject [accumulo] branch main updated: Revert "Update Last Location. Fix #1169 (#1616)"
Date Mon, 14 Sep 2020 17:03:59 GMT
This is an automated email from the ASF dual-hosted git repository.

ctubbsii pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/main by this push:
     new 33b9e4c  Revert "Update Last Location. Fix #1169  (#1616)"
33b9e4c is described below

commit 33b9e4c0cebcd797a317a015c65bce2a863b4ba4
Author: Christopher Tubbs <ctubbsii@apache.org>
AuthorDate: Mon Sep 14 13:02:28 2020 -0400

    Revert "Update Last Location. Fix #1169  (#1616)"
    
    This reverts commit 1c0f8df4ebf7ecb75cde889b32fcdbcfeaf4689d.
    
    This changed the behavior of updating the LAST location field to update
    on assignment, rather than on writing data to DFS. The LAST location
    field should be updated when writing data to DFS, because it identifies
    the location where the tablet last wrote data, so that a balancing
    strategy can re-assign it to a location where at least some data is
    local.
---
 .../java/org/apache/accumulo/server/master/state/MetaDataStateStore.java | 1 -
 .../java/org/apache/accumulo/test/functional/MasterAssignmentIT.java     | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/base/src/main/java/org/apache/accumulo/server/master/state/MetaDataStateStore.java
b/server/base/src/main/java/org/apache/accumulo/server/master/state/MetaDataStateStore.java
index a3d1c42..6061f56 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/master/state/MetaDataStateStore.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/master/state/MetaDataStateStore.java
@@ -65,7 +65,6 @@ class MetaDataStateStore implements TabletStateStore {
       for (Assignment assignment : assignments) {
         Mutation m = new Mutation(assignment.tablet.toMetaRow());
         assignment.server.putLocation(m);
-        assignment.server.putLastLocation(m);
         assignment.server.clearFutureLocation(m);
         SuspendingTServer.clearSuspension(m);
         writer.addMutation(m);
diff --git a/test/src/main/java/org/apache/accumulo/test/functional/MasterAssignmentIT.java
b/test/src/main/java/org/apache/accumulo/test/functional/MasterAssignmentIT.java
index 225220f..d99006c 100644
--- a/test/src/main/java/org/apache/accumulo/test/functional/MasterAssignmentIT.java
+++ b/test/src/main/java/org/apache/accumulo/test/functional/MasterAssignmentIT.java
@@ -56,6 +56,7 @@ public class MasterAssignmentIT extends AccumuloClusterHarness {
         UtilWaitThread.sleep(250);
         newTablet = getTabletLocationState(c, tableId);
       } while (newTablet.current == null);
+      assertNull(newTablet.last);
       assertNull(newTablet.future);
 
       // put something in it


Mime
View raw message