accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubb...@apache.org
Subject [accumulo] branch master updated: Revert "Add exceptions to standalone IT property file loading. Closes #1168. (#1189)"
Date Mon, 24 Jun 2019 20:05:48 GMT
This is an automated email from the ASF dual-hosted git repository.

ctubbsii pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/master by this push:
     new bd892da  Revert "Add exceptions to standalone IT property file loading. Closes #1168.
(#1189)"
bd892da is described below

commit bd892dae5447864436084de2283858c4dee0fa47
Author: Christopher Tubbs <ctubbsii@apache.org>
AuthorDate: Mon Jun 24 16:04:32 2019 -0400

    Revert "Add exceptions to standalone IT property file loading. Closes #1168. (#1189)"
    
    This reverts commit 49767b4fdd25f85c3c2148d77906b0ae6712708d.
    
    This change caused 127 new IT failures and is being reverted, so these
    can be worked out first.
---
 .../harness/conf/AccumuloClusterPropertyConfiguration.java     | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/test/src/main/java/org/apache/accumulo/harness/conf/AccumuloClusterPropertyConfiguration.java
b/test/src/main/java/org/apache/accumulo/harness/conf/AccumuloClusterPropertyConfiguration.java
index 98bb45a..326430d 100644
--- a/test/src/main/java/org/apache/accumulo/harness/conf/AccumuloClusterPropertyConfiguration.java
+++ b/test/src/main/java/org/apache/accumulo/harness/conf/AccumuloClusterPropertyConfiguration.java
@@ -63,19 +63,19 @@ public abstract class AccumuloClusterPropertyConfiguration implements
AccumuloCl
         try {
           reader = new FileReader(f);
         } catch (FileNotFoundException e) {
-          throw new RuntimeException("Could not read properties from specified file: " +
propertyFile, e);
+          log.warn("Could not read properties from specified file: {}", propertyFile, e);
         }
 
         if (reader != null) {
           try {
             fileProperties.load(reader);
           } catch (IOException e) {
-            throw new RuntimeException("Could not load properties from specified file: "
+ propertyFile, e);
+            log.warn("Could not load properties from specified file: {}", propertyFile, e);
           } finally {
             try {
               reader.close();
             } catch (IOException e) {
-              throw new RuntimeException("Could not close reader", e);
+              log.warn("Could not close reader", e);
             }
           }
 
@@ -83,10 +83,10 @@ public abstract class AccumuloClusterPropertyConfiguration implements
AccumuloCl
           clientConf = fileProperties.getProperty(ACCUMULO_CLUSTER_CLIENT_CONF_KEY);
         }
       } else {
-        throw new RuntimeException("Property file (" + propertyFile + ") is not a readable
file");
+        log.debug("Property file ({}) is not a readable file", propertyFile);
       }
     } else {
-      throw new RuntimeException("No properties file found in " + ACCUMULO_IT_PROPERTIES_FILE);
+      log.debug("No properties file found in {}", ACCUMULO_IT_PROPERTIES_FILE);
     }
 
     if (clusterTypeValue == null) {


Mime
View raw message