accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmil...@apache.org
Subject [accumulo] branch master updated: Deprecate cumbersome CLI scan options (#1140)
Date Wed, 08 May 2019 20:56:39 GMT
This is an automated email from the ASF dual-hosted git repository.

mmiller pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/master by this push:
     new d87ac8e  Deprecate cumbersome CLI scan options (#1140)
d87ac8e is described below

commit d87ac8e78bd9cad4bceb5675e76b73f50e4b7c99
Author: Mike Miller <mmiller@apache.org>
AuthorDate: Wed May 8 16:56:33 2019 -0400

    Deprecate cumbersome CLI scan options (#1140)
    
    * Deprecate -fi -fm and -i Scan options
---
 .../java/org/apache/accumulo/shell/commands/ScanCommand.java   | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java b/shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java
index 4173d5f..3d7e0bb 100644
--- a/shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java
+++ b/shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java
@@ -218,9 +218,15 @@ public class ScanCommand extends Command {
     Class<? extends ScanInterpreter> clazz = null;
     try {
       if (cl.hasOption(interpreterOpt.getOpt())) {
+        Shell.log.warn(
+            "Scan Interpreter option is deprecated and will be removed in a future version.\n");
+
         clazz = AccumuloVFSClassLoader.loadClass(cl.getOptionValue(interpreterOpt.getOpt()),
             ScanInterpreter.class);
       } else if (cl.hasOption(formatterInterpeterOpt.getOpt())) {
+        Shell.log.warn(
+            "Scan Interpreter option is deprecated and will be removed in a future version.\n");
+
         clazz = AccumuloVFSClassLoader.loadClass(cl.getOptionValue(formatterInterpeterOpt.getOpt()),
             ScanInterpreter.class);
       }
@@ -242,9 +248,13 @@ public class ScanCommand extends Command {
 
     try {
       if (cl.hasOption(formatterOpt.getOpt())) {
+        Shell.log.warn("Formatter option is deprecated and will be removed in a future version.\n");
+
         return shellState.getClassLoader(cl, shellState)
             .loadClass(cl.getOptionValue(formatterOpt.getOpt())).asSubclass(Formatter.class);
       } else if (cl.hasOption(formatterInterpeterOpt.getOpt())) {
+        Shell.log.warn("Formatter option is deprecated and will be removed in a future version.\n");
+
         return shellState.getClassLoader(cl, shellState)
             .loadClass(cl.getOptionValue(formatterInterpeterOpt.getOpt()))
             .asSubclass(Formatter.class);


Mime
View raw message