From commits-return-21689-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Fri Apr 6 11:53:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 61310180649 for ; Fri, 6 Apr 2018 11:53:03 +0200 (CEST) Received: (qmail 64832 invoked by uid 500); 6 Apr 2018 09:53:02 -0000 Mailing-List: contact commits-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list commits@accumulo.apache.org Received: (qmail 64822 invoked by uid 99); 6 Apr 2018 09:53:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2018 09:53:02 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 022178503C; Fri, 6 Apr 2018 09:53:02 +0000 (UTC) Date: Fri, 06 Apr 2018 09:53:03 +0000 To: "commits@accumulo.apache.org" Subject: [accumulo] 03/05: Fix findbugs error due to line-wrapping MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: ctubbsii@apache.org In-Reply-To: <152300838083.2308.13070823189703767346@gitbox.apache.org> References: <152300838083.2308.13070823189703767346@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: accumulo X-Git-Refname: refs/heads/1.8 X-Git-Reftype: branch X-Git-Rev: 2387957f92cc7cd3ca6120b331b0a759f7afd8c1 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20180406095302.022178503C@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. ctubbsii pushed a commit to branch 1.8 in repository https://gitbox.apache.org/repos/asf/accumulo.git commit 2387957f92cc7cd3ca6120b331b0a759f7afd8c1 Author: Christopher Tubbs AuthorDate: Fri Apr 6 00:01:12 2018 -0400 Fix findbugs error due to line-wrapping Fix findbugs error due to known false-positive issue from line-wrapping: https://github.com/spotbugs/spotbugs/issues/462 --- .../org/apache/accumulo/server/master/balancer/GroupBalancer.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java b/server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java index 3d8a33f..f57e46a 100644 --- a/server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java +++ b/server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java @@ -374,8 +374,9 @@ public abstract class GroupBalancer extends TabletBalancer { Integer extraCount = extraCounts.get(group); - checkArgument(extraCount != null && extraCount >= num, "group=%s num=%s extraCount=%s", group, - num, extraCount); + // don't wrap precondition check due to https://github.com/spotbugs/spotbugs/issues/462 + String formatString = "group=%s num=%s extraCount=%s"; + checkArgument(extraCount != null && extraCount >= num, formatString, group, num, extraCount); MutableInt initialCount = initialCounts.get(group); -- To stop receiving notification emails like this one, please contact ctubbsii@apache.org.