accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubb...@apache.org
Subject [accumulo] 03/05: Fix findbugs error due to line-wrapping
Date Fri, 06 Apr 2018 09:53:03 GMT
This is an automated email from the ASF dual-hosted git repository.

ctubbsii pushed a commit to branch 1.8
in repository https://gitbox.apache.org/repos/asf/accumulo.git

commit 2387957f92cc7cd3ca6120b331b0a759f7afd8c1
Author: Christopher Tubbs <ctubbsii@apache.org>
AuthorDate: Fri Apr 6 00:01:12 2018 -0400

    Fix findbugs error due to line-wrapping
    
    Fix findbugs error due to known false-positive issue from line-wrapping:
    https://github.com/spotbugs/spotbugs/issues/462
---
 .../org/apache/accumulo/server/master/balancer/GroupBalancer.java    | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
b/server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
index 3d8a33f..f57e46a 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
@@ -374,8 +374,9 @@ public abstract class GroupBalancer extends TabletBalancer {
 
       Integer extraCount = extraCounts.get(group);
 
-      checkArgument(extraCount != null && extraCount >= num, "group=%s num=%s
extraCount=%s", group,
-          num, extraCount);
+      // don't wrap precondition check due to https://github.com/spotbugs/spotbugs/issues/462
+      String formatString = "group=%s num=%s extraCount=%s";
+      checkArgument(extraCount != null && extraCount >= num, formatString, group,
num, extraCount);
 
       MutableInt initialCount = initialCounts.get(group);
 

-- 
To stop receiving notification emails like this one, please contact
ctubbsii@apache.org.

Mime
View raw message