accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubb...@apache.org
Subject [accumulo] branch master updated: Fix broken ConnectorImpl
Date Tue, 10 Apr 2018 21:28:01 GMT
This is an automated email from the ASF dual-hosted git repository.

ctubbsii pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/master by this push:
     new d73b46a  Fix broken ConnectorImpl
d73b46a is described below

commit d73b46a3d5de8a6e61433afb8fc62feeefc572d4
Author: Christopher Tubbs <ctubbsii@apache.org>
AuthorDate: Tue Apr 10 17:26:10 2018 -0400

    Fix broken ConnectorImpl
    
    Found and fixed broken switch cases (fall-through) in ConnectorImpl,
    based on (non-deprecation related) compiler warnings.
    
    Also fixed another warning about unused variables from a MapReduce IT.
---
 .../main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java  | 2 ++
 .../org/apache/accumulo/test/mapreduce/AccumuloOutputFormatIT.java     | 3 ---
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java b/core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java
index d2f9a63..1078932 100644
--- a/core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java
+++ b/core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java
@@ -377,6 +377,7 @@ public class ConnectorImpl extends Connector {
           } catch (IOException e) {
             throw new IllegalArgumentException(e);
           }
+          break;
         case "provider":
           String name = ClientProperty.AUTH_PROVIDER_NAME.getValue(properties);
           String providerUrls = ClientProperty.AUTH_PROVIDER_URLS.getValue(properties);
@@ -385,6 +386,7 @@ public class ConnectorImpl extends Connector {
           } catch (IOException e) {
             throw new IllegalArgumentException(e);
           }
+          break;
         default:
           throw new IllegalArgumentException(
               "An authentication method (password, kerberos, etc) must be set");
diff --git a/test/src/main/java/org/apache/accumulo/test/mapreduce/AccumuloOutputFormatIT.java
b/test/src/main/java/org/apache/accumulo/test/mapreduce/AccumuloOutputFormatIT.java
index 13922a0..04696e0 100644
--- a/test/src/main/java/org/apache/accumulo/test/mapreduce/AccumuloOutputFormatIT.java
+++ b/test/src/main/java/org/apache/accumulo/test/mapreduce/AccumuloOutputFormatIT.java
@@ -32,7 +32,6 @@ import org.apache.accumulo.core.client.Connector;
 import org.apache.accumulo.core.client.Scanner;
 import org.apache.accumulo.core.client.mapreduce.AccumuloInputFormat;
 import org.apache.accumulo.core.client.mapreduce.AccumuloOutputFormat;
-import org.apache.accumulo.core.client.security.tokens.AuthenticationToken;
 import org.apache.accumulo.core.data.Key;
 import org.apache.accumulo.core.data.Mutation;
 import org.apache.accumulo.core.data.Value;
@@ -85,8 +84,6 @@ public class AccumuloOutputFormatIT extends AccumuloClusterHarness {
             "Usage : " + MRTester.class.getName() + " <inputtable> <outputtable>");
       }
 
-      String user = getAdminPrincipal();
-      AuthenticationToken pass = getAdminToken();
       String table1 = args[0];
       String table2 = args[1];
 

-- 
To stop receiving notification emails like this one, please contact
ctubbsii@apache.org.

Mime
View raw message