Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DADC4200CE0 for ; Thu, 6 Jul 2017 00:57:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D8D5F164B3C; Wed, 5 Jul 2017 22:57:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2A2A3164B3D for ; Thu, 6 Jul 2017 00:57:27 +0200 (CEST) Received: (qmail 44843 invoked by uid 500); 5 Jul 2017 22:57:26 -0000 Mailing-List: contact commits-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list commits@accumulo.apache.org Received: (qmail 44761 invoked by uid 99); 5 Jul 2017 22:57:26 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jul 2017 22:57:26 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D0143E9687; Wed, 5 Jul 2017 22:57:25 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ctubbsii@apache.org To: commits@accumulo.apache.org Date: Wed, 05 Jul 2017 22:57:27 -0000 Message-Id: In-Reply-To: <419b06c8581d48909ab0d0392631539d@git.apache.org> References: <419b06c8581d48909ab0d0392631539d@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [3/7] accumulo git commit: ACCUMULO-4676 Use HTTPOnly flags in monitor archived-at: Wed, 05 Jul 2017 22:57:28 -0000 ACCUMULO-4676 Use HTTPOnly flags in monitor Add missing HTTPOnly flags on the JSESSIONID cookie in Monitor UI This prevents certain kinds of XSS attacks by preventing well-implemented browsers from allowing client-side code to access and modify the JSESSIONID cookie. This closes #278 Signed-off-by: Christopher Tubbs Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/9e7e3584 Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/9e7e3584 Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/9e7e3584 Branch: refs/heads/master Commit: 9e7e35842722b45b7bce0b13833d3dab0925e443 Parents: 3d552ea Author: Toshihiro Suzuki Authored: Tue Jul 4 14:05:03 2017 +0900 Committer: Christopher Tubbs Committed: Wed Jul 5 18:29:02 2017 -0400 ---------------------------------------------------------------------- .../main/java/org/apache/accumulo/monitor/EmbeddedWebServer.java | 2 ++ 1 file changed, 2 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/accumulo/blob/9e7e3584/server/monitor/src/main/java/org/apache/accumulo/monitor/EmbeddedWebServer.java ---------------------------------------------------------------------- diff --git a/server/monitor/src/main/java/org/apache/accumulo/monitor/EmbeddedWebServer.java b/server/monitor/src/main/java/org/apache/accumulo/monitor/EmbeddedWebServer.java index f0213e7..d57b751 100644 --- a/server/monitor/src/main/java/org/apache/accumulo/monitor/EmbeddedWebServer.java +++ b/server/monitor/src/main/java/org/apache/accumulo/monitor/EmbeddedWebServer.java @@ -82,6 +82,8 @@ public class EmbeddedWebServer { connector.setPort(port); handler = new ServletContextHandler(server, "/", new SessionHandler(), new ConstraintSecurityHandler(), null, null); + handler.getSessionHandler().getSessionManager().getSessionCookieConfig().setHttpOnly(true); + disableTrace("/"); }