accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubb...@apache.org
Subject [9/9] accumulo git commit: ACCUMULO-4685 Fix minor warnings
Date Mon, 24 Jul 2017 21:26:44 GMT
ACCUMULO-4685 Fix minor warnings

* Fix generics type safety warnings in YieldingIterator code
* Remove unused variable in ChaoticBalancerIT


Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/cbce8101
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/cbce8101
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/cbce8101

Branch: refs/heads/master
Commit: cbce8101b8f5331f4551f588652b6232017875c8
Parents: 8df7a8e
Author: Christopher Tubbs <ctubbsii@apache.org>
Authored: Mon Jul 24 17:14:07 2017 -0400
Committer: Christopher Tubbs <ctubbsii@apache.org>
Committed: Mon Jul 24 17:14:07 2017 -0400

----------------------------------------------------------------------
 .../apache/accumulo/iteratortest/testcases/YieldingTestCase.java | 2 +-
 .../org/apache/accumulo/test/functional/ChaoticBalancerIT.java   | 4 ++--
 .../org/apache/accumulo/test/functional/YieldingIterator.java    | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/accumulo/blob/cbce8101/iterator-test-harness/src/main/java/org/apache/accumulo/iteratortest/testcases/YieldingTestCase.java
----------------------------------------------------------------------
diff --git a/iterator-test-harness/src/main/java/org/apache/accumulo/iteratortest/testcases/YieldingTestCase.java
b/iterator-test-harness/src/main/java/org/apache/accumulo/iteratortest/testcases/YieldingTestCase.java
index 71943d5..b20bdd6 100644
--- a/iterator-test-harness/src/main/java/org/apache/accumulo/iteratortest/testcases/YieldingTestCase.java
+++ b/iterator-test-harness/src/main/java/org/apache/accumulo/iteratortest/testcases/YieldingTestCase.java
@@ -45,7 +45,7 @@ public class YieldingTestCase extends OutputVerifyingTestCase {
     try {
       skvi.init(source, testInput.getIteratorOptions(), new SimpleIteratorEnvironment());
 
-      YieldCallback<Key> yield = new YieldCallback();
+      YieldCallback<Key> yield = new YieldCallback<>();
       skvi.enableYielding(yield);
 
       skvi.seek(testInput.getRange(), testInput.getFamilies(), testInput.isInclusive());

http://git-wip-us.apache.org/repos/asf/accumulo/blob/cbce8101/test/src/main/java/org/apache/accumulo/test/functional/ChaoticBalancerIT.java
----------------------------------------------------------------------
diff --git a/test/src/main/java/org/apache/accumulo/test/functional/ChaoticBalancerIT.java
b/test/src/main/java/org/apache/accumulo/test/functional/ChaoticBalancerIT.java
index e5222c5..d7e5129 100644
--- a/test/src/main/java/org/apache/accumulo/test/functional/ChaoticBalancerIT.java
+++ b/test/src/main/java/org/apache/accumulo/test/functional/ChaoticBalancerIT.java
@@ -54,8 +54,8 @@ public class ChaoticBalancerIT extends AccumuloClusterHarness {
   @Test
   public void test() throws Exception {
     Connector c = getConnector();
-    String[] names = getUniqueNames(2);
-    String tableName = names[0], unused = names[1];
+    String[] names = getUniqueNames(1);
+    String tableName = names[0];
     NewTableConfiguration ntc = new NewTableConfiguration();
     ntc.setProperties(Stream.of(new Pair<>(Property.TABLE_LOAD_BALANCER.getKey(), ChaoticLoadBalancer.class.getName()),
         new Pair<>(Property.TABLE_SPLIT_THRESHOLD.getKey(), "10K"), new Pair<>(Property.TABLE_FILE_COMPRESSED_BLOCK_SIZE.getKey(),
"1K")).collect(

http://git-wip-us.apache.org/repos/asf/accumulo/blob/cbce8101/test/src/main/java/org/apache/accumulo/test/functional/YieldingIterator.java
----------------------------------------------------------------------
diff --git a/test/src/main/java/org/apache/accumulo/test/functional/YieldingIterator.java
b/test/src/main/java/org/apache/accumulo/test/functional/YieldingIterator.java
index bad124e..a7881d1 100644
--- a/test/src/main/java/org/apache/accumulo/test/functional/YieldingIterator.java
+++ b/test/src/main/java/org/apache/accumulo/test/functional/YieldingIterator.java
@@ -121,7 +121,7 @@ public class YieldingIterator extends WrappingIterator {
   }
 
   @Override
-  public void enableYielding(YieldCallback yield) {
+  public void enableYielding(YieldCallback<Key> yield) {
     this.yield = Optional.of(yield);
   }
 }


Mime
View raw message