Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 17F56200B74 for ; Fri, 22 Jul 2016 04:58:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 17125160A7C; Fri, 22 Jul 2016 02:58:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 81617160A9C for ; Fri, 22 Jul 2016 04:58:56 +0200 (CEST) Received: (qmail 76067 invoked by uid 500); 22 Jul 2016 02:58:55 -0000 Mailing-List: contact commits-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list commits@accumulo.apache.org Received: (qmail 75631 invoked by uid 99); 22 Jul 2016 02:58:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jul 2016 02:58:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 437CFEAB5D; Fri, 22 Jul 2016 02:58:55 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ctubbsii@apache.org To: commits@accumulo.apache.org Date: Fri, 22 Jul 2016 02:59:09 -0000 Message-Id: <12e70abae74b4b9586b399a0b613b16d@git.apache.org> In-Reply-To: <8930e8a27601403ca60b6d8ca8e92dd7@git.apache.org> References: <8930e8a27601403ca60b6d8ca8e92dd7@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [15/16] accumulo git commit: ACCUMULO-4386 Fix trivial compiler warnings archived-at: Fri, 22 Jul 2016 02:58:58 -0000 ACCUMULO-4386 Fix trivial compiler warnings Fix extra import and use generic method for emptyMap() instead of EMPTY_MAP constant. Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/c587a6f5 Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/c587a6f5 Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/c587a6f5 Branch: refs/heads/1.8 Commit: c587a6f5607b211fa6d7d542f3694cac814956c0 Parents: 4980eec Author: Christopher Tubbs Authored: Thu Jul 21 22:52:24 2016 -0400 Committer: Christopher Tubbs Committed: Thu Jul 21 22:52:24 2016 -0400 ---------------------------------------------------------------------- .../minicluster/impl/MiniAccumuloClusterControl.java | 2 +- .../org/apache/accumulo/master/TabletGroupWatcher.java | 11 +++++------ 2 files changed, 6 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/accumulo/blob/c587a6f5/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterControl.java ---------------------------------------------------------------------- diff --git a/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterControl.java b/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterControl.java index 688cb5d..9a433cf 100644 --- a/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterControl.java +++ b/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterControl.java @@ -134,7 +134,7 @@ public class MiniAccumuloClusterControl implements ClusterControl { @Override public synchronized void start(ServerType server, String hostname) throws IOException { - start(server, hostname, Collections.EMPTY_MAP, Integer.MAX_VALUE); + start(server, hostname, Collections. emptyMap(), Integer.MAX_VALUE); } public synchronized void start(ServerType server, String hostname, Map configOverrides, int limit) throws IOException { http://git-wip-us.apache.org/repos/asf/accumulo/blob/c587a6f5/server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java ---------------------------------------------------------------------- diff --git a/server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java b/server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java index 2cf7d9d..76fda21 100644 --- a/server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java +++ b/server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java @@ -16,8 +16,8 @@ */ package org.apache.accumulo.master; -import com.google.common.collect.ImmutableSortedSet; import static com.google.common.util.concurrent.Uninterruptibles.sleepUninterruptibly; +import static java.lang.Math.min; import java.io.IOException; import java.util.ArrayList; @@ -29,6 +29,7 @@ import java.util.Map; import java.util.Map.Entry; import java.util.Set; import java.util.SortedMap; +import java.util.SortedSet; import java.util.TreeMap; import java.util.TreeSet; import java.util.concurrent.TimeUnit; @@ -43,6 +44,7 @@ import org.apache.accumulo.core.client.MutationsRejectedException; import org.apache.accumulo.core.client.RowIterator; import org.apache.accumulo.core.client.Scanner; import org.apache.accumulo.core.client.TableNotFoundException; +import org.apache.accumulo.core.conf.Property; import org.apache.accumulo.core.data.Key; import org.apache.accumulo.core.data.Mutation; import org.apache.accumulo.core.data.PartialKey; @@ -67,6 +69,7 @@ import org.apache.accumulo.master.state.MergeStats; import org.apache.accumulo.master.state.TableCounts; import org.apache.accumulo.master.state.TableStats; import org.apache.accumulo.server.ServerConstants; +import org.apache.accumulo.server.conf.TableConfiguration; import org.apache.accumulo.server.fs.FileRef; import org.apache.accumulo.server.fs.VolumeManager.FileType; import org.apache.accumulo.server.log.WalStateManager; @@ -91,12 +94,8 @@ import org.apache.hadoop.io.Text; import org.apache.thrift.TException; import com.google.common.base.Optional; +import com.google.common.collect.ImmutableSortedSet; import com.google.common.collect.Iterators; -import org.apache.accumulo.core.conf.Property; -import org.apache.accumulo.server.conf.TableConfiguration; -import static java.lang.Math.min; -import java.util.SortedSet; -import static java.lang.Math.min; abstract class TabletGroupWatcher extends Daemon { // Constants used to make sure assignment logging isn't excessive in quantity or size