Return-Path: X-Original-To: apmail-accumulo-commits-archive@www.apache.org Delivered-To: apmail-accumulo-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 22C2918363 for ; Thu, 28 May 2015 03:07:00 +0000 (UTC) Received: (qmail 67168 invoked by uid 500); 28 May 2015 03:07:00 -0000 Delivered-To: apmail-accumulo-commits-archive@accumulo.apache.org Received: (qmail 67060 invoked by uid 500); 28 May 2015 03:07:00 -0000 Mailing-List: contact commits-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list commits@accumulo.apache.org Received: (qmail 67040 invoked by uid 99); 28 May 2015 03:06:59 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 May 2015 03:06:59 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C7AC0E0505; Thu, 28 May 2015 03:06:59 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: elserj@apache.org To: commits@accumulo.apache.org Date: Thu, 28 May 2015 03:07:00 -0000 Message-Id: <535ff65bd88346a695067cd50a4f8485@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [2/3] accumulo git commit: ACCUMULO-3861 durability=none might still see all results. ACCUMULO-3861 durability=none might still see all results. It's extremely unlikely, but it apparently is possible since it failed for me in that way (best I can tell). Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/f9a29c77 Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/f9a29c77 Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/f9a29c77 Branch: refs/heads/master Commit: f9a29c77d28e5f2de218741c07fdec4ad49228fb Parents: 98fbe4f Author: Josh Elser Authored: Wed May 27 22:52:28 2015 -0400 Committer: Josh Elser Committed: Wed May 27 22:52:28 2015 -0400 ---------------------------------------------------------------------- .../org/apache/accumulo/test/functional/DurabilityIT.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/accumulo/blob/f9a29c77/test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java ---------------------------------------------------------------------- diff --git a/test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java b/test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java index aa280dc..9a262a1 100644 --- a/test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java +++ b/test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java @@ -130,7 +130,8 @@ public class DurabilityIT extends ConfigurableMacIT { // we're probably going to lose something the the log setting writeSome(tableNames[2], N); restartTServer(); - assertTrue(N >= readSome(tableNames[2])); + long numResults = readSome(tableNames[2]); + assertTrue("Expected " + N + " >= " + numResults, N >= numResults); cleanup(tableNames); } @@ -140,7 +141,8 @@ public class DurabilityIT extends ConfigurableMacIT { // probably won't get any data back without logging writeSome(tableNames[3], N); restartTServer(); - assertTrue(N > readSome(tableNames[3])); + long numResults = readSome(tableNames[3]); + assertTrue("Expected " + N + " >= " + numResults, N >= numResults); cleanup(tableNames); } @@ -152,7 +154,8 @@ public class DurabilityIT extends ConfigurableMacIT { c.tableOperations().setProperty(tableName, Property.TABLE_DURABILITY.getKey(), "none"); writeSome(tableName, N); restartTServer(); - assertTrue(N > readSome(tableName)); + long numResults = readSome(tableName); + assertTrue("Expected " + N + " >= " + numResults, N >= numResults); c.tableOperations().setProperty(tableName, Property.TABLE_DURABILITY.getKey(), "sync"); writeSome(tableName, N); restartTServer();