accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From els...@apache.org
Subject [1/3] accumulo git commit: ACCUMULO-3861 durability=none might still see all results.
Date Thu, 28 May 2015 03:06:59 GMT
Repository: accumulo
Updated Branches:
  refs/heads/1.7 98fbe4f14 -> f9a29c77d
  refs/heads/master ae2255c87 -> 8c1d2d0c1


ACCUMULO-3861 durability=none might still see all results.

It's extremely unlikely, but it apparently is possible since
it failed for me in that way (best I can tell).


Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/f9a29c77
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/f9a29c77
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/f9a29c77

Branch: refs/heads/1.7
Commit: f9a29c77d28e5f2de218741c07fdec4ad49228fb
Parents: 98fbe4f
Author: Josh Elser <elserj@apache.org>
Authored: Wed May 27 22:52:28 2015 -0400
Committer: Josh Elser <elserj@apache.org>
Committed: Wed May 27 22:52:28 2015 -0400

----------------------------------------------------------------------
 .../org/apache/accumulo/test/functional/DurabilityIT.java   | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/accumulo/blob/f9a29c77/test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java
----------------------------------------------------------------------
diff --git a/test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java b/test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java
index aa280dc..9a262a1 100644
--- a/test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java
+++ b/test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java
@@ -130,7 +130,8 @@ public class DurabilityIT extends ConfigurableMacIT {
     // we're probably going to lose something the the log setting
     writeSome(tableNames[2], N);
     restartTServer();
-    assertTrue(N >= readSome(tableNames[2]));
+    long numResults = readSome(tableNames[2]);
+    assertTrue("Expected " + N + " >= " + numResults, N >= numResults);
     cleanup(tableNames);
   }
 
@@ -140,7 +141,8 @@ public class DurabilityIT extends ConfigurableMacIT {
     // probably won't get any data back without logging
     writeSome(tableNames[3], N);
     restartTServer();
-    assertTrue(N > readSome(tableNames[3]));
+    long numResults = readSome(tableNames[3]);
+    assertTrue("Expected " + N + " >= " + numResults, N >= numResults);
     cleanup(tableNames);
   }
 
@@ -152,7 +154,8 @@ public class DurabilityIT extends ConfigurableMacIT {
     c.tableOperations().setProperty(tableName, Property.TABLE_DURABILITY.getKey(), "none");
     writeSome(tableName, N);
     restartTServer();
-    assertTrue(N > readSome(tableName));
+    long numResults = readSome(tableName);
+    assertTrue("Expected " + N + " >= " + numResults, N >= numResults);
     c.tableOperations().setProperty(tableName, Property.TABLE_DURABILITY.getKey(), "sync");
     writeSome(tableName, N);
     restartTServer();


Mime
View raw message