accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubb...@apache.org
Subject accumulo git commit: ACCUMULO-3415 VolumeManager members should be more restricted
Date Mon, 11 May 2015 15:48:37 GMT
Repository: accumulo
Updated Branches:
  refs/heads/master 781bdf1ee -> 988c3c11a


ACCUMULO-3415 VolumeManager members should be more restricted

Made member variables private and final and removed the AccumuloConfiguration conf as this
was not being used.

Signed-off-by: Christopher Tubbs <ctubbsii@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/988c3c11
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/988c3c11
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/988c3c11

Branch: refs/heads/master
Commit: 988c3c11af119b8d81489b475accd319ca60e398
Parents: 781bdf1
Author: Steve Blackmore <steveblackmore10@gmail.com>
Authored: Sun May 10 22:47:33 2015 +0100
Committer: Christopher Tubbs <ctubbsii@apache.org>
Committed: Mon May 11 11:44:24 2015 -0400

----------------------------------------------------------------------
 .../org/apache/accumulo/server/fs/VolumeManagerImpl.java  | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/accumulo/blob/988c3c11/server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java
b/server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java
index d167dd2..b5ba5b5 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java
@@ -67,11 +67,10 @@ public class VolumeManagerImpl implements VolumeManager {
 
   private static final HashSet<String> WARNED_ABOUT_SYNCONCLOSE = new HashSet<String>();
 
-  Map<String,Volume> volumesByName;
-  Multimap<URI,Volume> volumesByFileSystemUri;
-  Volume defaultVolume;
-  AccumuloConfiguration conf;
-  VolumeChooser chooser;
+  private final Map<String,Volume> volumesByName;
+  private final Multimap<URI,Volume> volumesByFileSystemUri;
+  private final Volume defaultVolume;
+  private final VolumeChooser chooser;
 
   protected VolumeManagerImpl(Map<String,Volume> volumes, Volume defaultVolume, AccumuloConfiguration
conf) {
     this.volumesByName = volumes;
@@ -79,7 +78,6 @@ public class VolumeManagerImpl implements VolumeManager {
     // We may have multiple directories used in a single FileSystem (e.g. testing)
     this.volumesByFileSystemUri = HashMultimap.create();
     invertVolumesByFileSystem(volumesByName, volumesByFileSystemUri);
-    this.conf = conf;
     ensureSyncIsEnabled();
     // Keep in sync with default type in the property definition.
     chooser = Property.createInstanceFromPropertyName(conf, Property.GENERAL_VOLUME_CHOOSER,
VolumeChooser.class, new PerTableVolumeChooser());


Mime
View raw message