accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From els...@apache.org
Subject [1/3] accumulo git commit: ACCUMULO-3730 Make getZooKeepersFromDir private again.
Date Thu, 16 Apr 2015 01:02:20 GMT
Repository: accumulo
Updated Branches:
  refs/heads/master d71dbe640 -> cf69821d5


ACCUMULO-3730 Make getZooKeepersFromDir private again.

This method shouldn't leak into the public API. Add
a comment to make sure it doesn't happen.


Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/cf69821d
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/cf69821d
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/cf69821d

Branch: refs/heads/master
Commit: cf69821d5ff29ae552e7ac65bcef979a8c4dfafb
Parents: 3ad1950
Author: Josh Elser <elserj@apache.org>
Authored: Tue Apr 14 17:43:16 2015 -0400
Committer: Josh Elser <elserj@apache.org>
Committed: Wed Apr 15 20:36:38 2015 -0400

----------------------------------------------------------------------
 .../org/apache/accumulo/minicluster/MiniAccumuloInstance.java     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/accumulo/blob/cf69821d/minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java
----------------------------------------------------------------------
diff --git a/minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java
b/minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java
index b94cb0b..095bae2 100644
--- a/minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java
+++ b/minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java
@@ -50,7 +50,8 @@ public class MiniAccumuloInstance extends ZooKeeperInstance {
     }
   }
 
-  public static String getZooKeepersFromDir(File directory) throws FileNotFoundException
{
+  // Keep this private to avoid bringing it into the public API
+  private static String getZooKeepersFromDir(File directory) throws FileNotFoundException
{
     if (!directory.isDirectory())
       throw new IllegalArgumentException("Not a directory " + directory.getPath());
     File configFile = new File(new File(directory, "conf"), "accumulo-site.xml");


Mime
View raw message