Return-Path: X-Original-To: apmail-accumulo-commits-archive@www.apache.org Delivered-To: apmail-accumulo-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D49010E09 for ; Tue, 9 Dec 2014 18:15:39 +0000 (UTC) Received: (qmail 70982 invoked by uid 500); 9 Dec 2014 18:15:39 -0000 Delivered-To: apmail-accumulo-commits-archive@accumulo.apache.org Received: (qmail 70926 invoked by uid 500); 9 Dec 2014 18:15:39 -0000 Mailing-List: contact commits-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list commits@accumulo.apache.org Received: (qmail 70910 invoked by uid 99); 9 Dec 2014 18:15:38 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Dec 2014 18:15:38 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id BA4B8A212BC; Tue, 9 Dec 2014 18:15:38 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: elserj@apache.org To: commits@accumulo.apache.org Date: Tue, 09 Dec 2014 18:15:39 -0000 Message-Id: In-Reply-To: <2b3e56aaac6f4f9eb831a9d3c5a71068@git.apache.org> References: <2b3e56aaac6f4f9eb831a9d3c5a71068@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/3] accumulo git commit: ACCUMULO-3395 Keep a reference to a single Logger instance. ACCUMULO-3395 Keep a reference to a single Logger instance. Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/98c524e3 Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/98c524e3 Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/98c524e3 Branch: refs/heads/master Commit: 98c524e3425678286872952ce376a4aa774079a5 Parents: 6170c02 Author: Josh Elser Authored: Tue Dec 9 13:11:03 2014 -0500 Committer: Josh Elser Committed: Tue Dec 9 13:11:03 2014 -0500 ---------------------------------------------------------------------- .../main/java/org/apache/accumulo/server/util/RpcWrapper.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/accumulo/blob/98c524e3/server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---------------------------------------------------------------------- diff --git a/server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java b/server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java index 02bd1ef..7055053 100644 --- a/server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java +++ b/server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java @@ -24,6 +24,7 @@ import org.apache.accumulo.trace.instrument.thrift.RpcServerInvocationHandler; import org.apache.accumulo.trace.instrument.thrift.TraceWrap; import org.apache.thrift.TApplicationException; import org.apache.thrift.TException; +import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** @@ -38,17 +39,18 @@ public class RpcWrapper { public static T service(final T instance) { InvocationHandler handler = new RpcServerInvocationHandler(instance) { + private final Logger log = LoggerFactory.getLogger(instance.getClass()); @Override public Object invoke(Object obj, Method method, Object[] args) throws Throwable { try { return super.invoke(obj, method, args); } catch (RuntimeException e) { String msg = e.getMessage(); - LoggerFactory.getLogger(instance.getClass()).error(msg, e); + log.error(msg, e); throw new TException(msg); } catch (Error e) { String msg = e.getMessage(); - LoggerFactory.getLogger(instance.getClass()).error(msg, e); + log.error(msg, e); throw new TException(msg); } }