Return-Path: X-Original-To: apmail-accumulo-commits-archive@www.apache.org Delivered-To: apmail-accumulo-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1BE4F17C2B for ; Tue, 4 Nov 2014 21:09:30 +0000 (UTC) Received: (qmail 97295 invoked by uid 500); 4 Nov 2014 21:09:29 -0000 Delivered-To: apmail-accumulo-commits-archive@accumulo.apache.org Received: (qmail 97178 invoked by uid 500); 4 Nov 2014 21:09:28 -0000 Mailing-List: contact commits-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list commits@accumulo.apache.org Received: (qmail 96659 invoked by uid 99); 4 Nov 2014 21:09:27 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Nov 2014 21:09:27 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 9F8018AEE75; Tue, 4 Nov 2014 21:09:27 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: elserj@apache.org To: commits@accumulo.apache.org Date: Tue, 04 Nov 2014 21:09:28 -0000 Message-Id: <3b391f52d8424cbb89bdebe482589c1c@git.apache.org> In-Reply-To: <792f87c975a14ff69b6032f05257baa3@git.apache.org> References: <792f87c975a14ff69b6032f05257baa3@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/3] git commit: ACCUMULO-3292 Some extra information on flat out incorrect assertion failures. ACCUMULO-3292 Some extra information on flat out incorrect assertion failures. Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/eb424221 Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/eb424221 Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/eb424221 Branch: refs/heads/master Commit: eb424221bafe583a37ad9c6a61b72d2820c37e46 Parents: 2805630 Author: Josh Elser Authored: Tue Nov 4 16:06:21 2014 -0500 Committer: Josh Elser Committed: Tue Nov 4 16:06:21 2014 -0500 ---------------------------------------------------------------------- .../accumulo/test/ConditionalWriterIT.java | 26 ++++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/accumulo/blob/eb424221/test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java ---------------------------------------------------------------------- diff --git a/test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java b/test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java index 1a7fe20..516cd46 100644 --- a/test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java +++ b/test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java @@ -357,8 +357,8 @@ public class ConditionalWriterIT extends SimpleMacIT { cm8.put("tx", "seq", cva, "1"); try { - cw2.write(cm8).getStatus(); - Assert.fail("Writing mutation with Authorizations the user doesn't have should fail"); + Status status = cw2.write(cm8).getStatus(); + Assert.fail("Writing mutation with Authorizations the user doesn't have should fail. Got status: " + status); } catch (AccumuloSecurityException ase) { // expected, check specific failure? } finally { @@ -1050,15 +1050,15 @@ public class ConditionalWriterIT extends SimpleMacIT { Assert.assertEquals(Status.ACCEPTED, cw3.write(cm1).getStatus()); try { - cw1.write(cm1).getStatus(); - Assert.fail("Expected exception writing conditional mutation to table the user doesn't have write access to"); + Status status = cw1.write(cm1).getStatus(); + Assert.fail("Expected exception writing conditional mutation to table the user doesn't have write access to, Got status: " + status); } catch (AccumuloSecurityException ase) { } try { - cw2.write(cm1).getStatus(); - Assert.fail("Expected exception writing conditional mutation to table the user doesn't have read access to"); + Status status = cw2.write(cm1).getStatus(); + Assert.fail("Expected exception writing conditional mutation to table the user doesn't have read access to. Got status: " + status); } catch (AccumuloSecurityException ase) { } @@ -1101,7 +1101,7 @@ public class ConditionalWriterIT extends SimpleMacIT { else if (cf.equals("data") && cq.equals("x")) Assert.assertEquals("Unexpected value in data:x", "a", val); else - Assert.fail("Saw unexpected column family and qualifier"); + Assert.fail("Saw unexpected column family and qualifier: " + entry); } ConditionalMutation cm3 = new ConditionalMutation("r1", new Condition("tx", "seq").setValue("1")); @@ -1136,8 +1136,8 @@ public class ConditionalWriterIT extends SimpleMacIT { Result result = cw.write(cm1); try { - result.getStatus(); - Assert.fail("Expected exception writing conditional mutation to deleted table"); + Status status = result.getStatus(); + Assert.fail("Expected exception writing conditional mutation to deleted table. Got status: " + status); } catch (AccumuloException ae) { Assert.assertEquals(TableDeletedException.class, ae.getCause().getClass()); } @@ -1161,8 +1161,8 @@ public class ConditionalWriterIT extends SimpleMacIT { Result result = cw.write(cm1); try { - result.getStatus(); - Assert.fail("Expected exception writing conditional mutation to offline table"); + Status status = result.getStatus(); + Assert.fail("Expected exception writing conditional mutation to offline table. Got status: " + status); } catch (AccumuloException ae) { Assert.assertEquals(TableOfflineException.class, ae.getCause().getClass()); } @@ -1193,8 +1193,8 @@ public class ConditionalWriterIT extends SimpleMacIT { Result result = cw.write(cm1); try { - result.getStatus(); - Assert.fail("Expected exception using iterator which throws an error"); + Status status = result.getStatus(); + Assert.fail("Expected exception using iterator which throws an error, Got status: " + status); } catch (AccumuloException ae) { }