accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From els...@apache.org
Subject [3/5] git commit: ACCUMULO-3045 Fix some misleading logging messages
Date Tue, 12 Aug 2014 03:41:59 GMT
ACCUMULO-3045 Fix some misleading logging messages


Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/011349e2
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/011349e2
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/011349e2

Branch: refs/heads/master
Commit: 011349e2d1536b7ddae166c98bc2f4590ae3df1d
Parents: 384aa39
Author: Josh Elser <elserj@apache.org>
Authored: Mon Aug 11 23:31:38 2014 -0400
Committer: Josh Elser <elserj@apache.org>
Committed: Mon Aug 11 23:31:38 2014 -0400

----------------------------------------------------------------------
 .../core/conf/CredentialProviderFactoryShim.java         | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/accumulo/blob/011349e2/core/src/main/java/org/apache/accumulo/core/conf/CredentialProviderFactoryShim.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/accumulo/core/conf/CredentialProviderFactoryShim.java
b/core/src/main/java/org/apache/accumulo/core/conf/CredentialProviderFactoryShim.java
index a1fd8c7..513b8cb 100644
--- a/core/src/main/java/org/apache/accumulo/core/conf/CredentialProviderFactoryShim.java
+++ b/core/src/main/java/org/apache/accumulo/core/conf/CredentialProviderFactoryShim.java
@@ -218,18 +218,19 @@ public class CredentialProviderFactoryShim {
         
         return (char[]) credential;
       } catch (IllegalArgumentException e) {
-        log.warn("Failed to get credential from {}", providerObj, e);
+        log.warn("Failed to get credential for {} from {}", alias, providerObj, e);
         continue;
       } catch (IllegalAccessException e) {
-        log.warn("Failed to get credential from {}", providerObj, e);
+        log.warn("Failed to get credential for {} from {}", alias, providerObj, e);
         continue;
       } catch (InvocationTargetException e) {
-        log.warn("Failed to get credential from {}", providerObj, e);
+        log.warn("Failed to get credential for {} from {}", alias, providerObj, e);
         continue;
       }
     }
-    
-    log.warn("Could not extract credential from providers");
+
+    // If we didn't find it, this isn't an error, it just wasn't set in the CredentialProvider
+    log.trace("Could not extract credential for {} from providers", alias);
     
     return null;
   }


Mime
View raw message