accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From els...@apache.org
Subject git commit: ACCUMULO-2913 If we compact the table(s) it's possible that the replication entry will be cleaned up.
Date Tue, 24 Jun 2014 19:04:14 GMT
Repository: accumulo
Updated Branches:
  refs/heads/master dc6e77694 -> 590b2cf25


ACCUMULO-2913 If we compact the table(s) it's possible that the replication entry will be
cleaned up.

For either table, if we compact them after writing the data, the tablet will remove its WAL
entry.
When no tablets reference that WAL anymore, it will be closed by the GC. Thus, the master
might
remove the closed entry, but out test case might not have been able to read the metadata table
to verify that the record was there.

By not compacting the tables, we can ensure that the record will definitely be there.


Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/590b2cf2
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/590b2cf2
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/590b2cf2

Branch: refs/heads/master
Commit: 590b2cf256d7a7475f988e1e5b668b90a07417e1
Parents: dc6e776
Author: Josh Elser <elserj@apache.org>
Authored: Tue Jun 24 14:42:31 2014 -0400
Committer: Josh Elser <elserj@apache.org>
Committed: Tue Jun 24 14:47:54 2014 -0400

----------------------------------------------------------------------
 .../org/apache/accumulo/test/replication/ReplicationIT.java  | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/accumulo/blob/590b2cf2/test/src/test/java/org/apache/accumulo/test/replication/ReplicationIT.java
----------------------------------------------------------------------
diff --git a/test/src/test/java/org/apache/accumulo/test/replication/ReplicationIT.java b/test/src/test/java/org/apache/accumulo/test/replication/ReplicationIT.java
index 4abe25a..b119d7b 100644
--- a/test/src/test/java/org/apache/accumulo/test/replication/ReplicationIT.java
+++ b/test/src/test/java/org/apache/accumulo/test/replication/ReplicationIT.java
@@ -286,8 +286,8 @@ public class ReplicationIT extends ConfigurableMacIT {
 
     bw.close();
 
-    // Compact the table1
-    conn.tableOperations().compact(table1, null, null, true, true);
+    // After the commit for these mutations finishes, we'll get a replication entry in accumulo.metadata
for table1
+    // Don't want to compact table1 as it ultimately cause the entry in accumulo.metadata
to be removed before we can verify it's there
 
     // After writing data, we'll get a replication table
     boolean exists = conn.tableOperations().exists(ReplicationTable.NAME);
@@ -344,8 +344,8 @@ public class ReplicationIT extends ConfigurableMacIT {
 
     bw.close();
 
-    // Compact the table2
-    conn.tableOperations().compact(table2, null, null, true, true);
+    // After the commit on these mutations, we'll get a replication entry in accumulo.metadata
for table2
+    // Don't want to compact table2 as it ultimately cause the entry in accumulo.metadata
to be removed before we can verify it's there
 
     // After writing data, we'll get a replication table
     Assert.assertTrue(conn.tableOperations().exists(ReplicationTable.NAME));


Mime
View raw message