accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From els...@apache.org
Subject [3/6] git commit: ACCUMULO-2254 Replace the findbugs scripts with instructions on how to invoke the findbugs-maven-plugin
Date Fri, 24 Jan 2014 18:43:52 GMT
ACCUMULO-2254 Replace the findbugs scripts with instructions on how to invoke the findbugs-maven-plugin


Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/8981ba04
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/8981ba04
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/8981ba04

Branch: refs/heads/master
Commit: 8981ba04e6e2e5a7c41175451e2b5e5e41401153
Parents: 1f96266
Author: Josh Elser <elserj@apache.org>
Authored: Fri Jan 24 13:42:22 2014 -0500
Committer: Josh Elser <elserj@apache.org>
Committed: Fri Jan 24 13:42:22 2014 -0500

----------------------------------------------------------------------
 contrib/README.findbugs    | 24 +++++++++++
 contrib/findbugs_build.xml | 96 -----------------------------------------
 contrib/run_findbugs.sh    | 18 --------
 3 files changed, 24 insertions(+), 114 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/accumulo/blob/8981ba04/contrib/README.findbugs
----------------------------------------------------------------------
diff --git a/contrib/README.findbugs b/contrib/README.findbugs
new file mode 100644
index 0000000..7e70014
--- /dev/null
+++ b/contrib/README.findbugs
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+# 
+#     http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+To generate a Findbugs report, invoke the following Maven command from the root
+of the project:
+
+`mvn clean package site site:stage`
+
+Activating the package lifecycle phase is necessary as recompilation of the 
+classes is necessary to get instrumentation from Findbugs. This will ultimately
+generate a local HTML site in `target/staging` which you can point your web
+browser to. Each submodule of the project will contain its own Findbugs report.

http://git-wip-us.apache.org/repos/asf/accumulo/blob/8981ba04/contrib/findbugs_build.xml
----------------------------------------------------------------------
diff --git a/contrib/findbugs_build.xml b/contrib/findbugs_build.xml
deleted file mode 100644
index b3fae14..0000000
--- a/contrib/findbugs_build.xml
+++ /dev/null
@@ -1,96 +0,0 @@
-<!--
-  Licensed to the Apache Software Foundation (ASF) under one or more
-  contributor license agreements.  See the NOTICE file distributed with
-  this work for additional information regarding copyright ownership.
-  The ASF licenses this file to You under the Apache License, Version 2.0
-  (the "License"); you may not use this file except in compliance with
-  the License.  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
--->
-<project name="accumulo" default="findbugs" basedir=".">
-  <description>
-  A build file to run findbugs.
-
-  STEP ONE
-  Download findbugs. Set FINDBUGS_HOME environment variable.
-  export FINDBUGS_HOME=/usr/local/findbugs-2.0.1
-
-  STEP TWO
-  To install the Ant task, copy findbugs-ant.jar into the 
-  lib subdirectory of your Ant installation. For example, I ran 
-  'sudo cp $FINDBUGS_HOME/lib/findbugs-ant.jar /usr/share/ant/lib'
-
-  STEP THREE
-  Run 'mvn install -P assemble'. This will copy the accumulo jar files into
-  the local maven repository.
-  </description>
-
-  <property environment="env"/>
-
-  <taskdef name="findbugs" classname="edu.umd.cs.findbugs.anttask.FindBugsTask"/>
-
-  <property name="findbugs.home" value="${env.FINDBUGS_HOME}" />
-
-  <target name="findbugs">
-    <!-- jvmargs="-Xms512M -Xmx512M" -->
-    <property name="repository" value="/home/${env.USER}/.m2/repository"/>
-    <findbugs home="${findbugs.home}" output="html" outputFile="accumulo.findbugs.html"
>
-      <auxClasspath>
-        <pathElement location="${repository}/ant/ant/1.6.5/ant-1.6.5.jar" />
-        <pathElement location="${repository}/commons-cli/commons-cli/1.2/commons-cli-1.2.jar"
/>
-        <pathElement location="${repository}/commons-codec/commons-codec/1.3/commons-codec-1.3.jar"
/>
-        <pathElement location="${repository}/commons-collections/commons-collections/3.2/commons-collections-3.2.jar"
/>
-        <pathElement location="${repository}/commons-configuration/commons-configuration/1.5/commons-configuration-1.5.jar"
/>
-        <pathElement location="${repository}/commons-io/commons-io/1.4/commons-io-1.4.jar"
/>
-        <pathElement location="${repository}/commons-lang/commons-lang/2.6/commons-lang-2.6.jar"
/>
-        <pathElement location="${repository}/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar"
/>
-        <pathElement location="${repository}/jline/jline/0.9.94/jline-0.9.94.jar" />
-        <pathElement location="${repository}/log4j/log4j/1.2.16/log4j-1.2.16.jar" />
-        <pathElement location="${repository}/org/apache/commons/commons-jci-fam/1.0/commons-jci-fam-1.0.jar"
/>
-        <pathElement location="${repository}/org/apache/hadoop/zookeeper/3.3.1/zookeeper-3.3.1.jar"
/>
-        <pathElement location="${repository}/org/apache/thrift/libthrift/0.8.0/libthrift-0.8.0.jar"
/>
-        <pathElement location="${repository}/org/apache/hadoop/hadoop-core/0.20.205.0/hadoop-core-0.20.205.0.jar"
/>
-        <pathElement location="${repository}/org/mortbay/jetty/jetty/6.1.26/jetty-6.1.26.jar"
/>
-        <pathElement location="${repository}/org/mortbay/jetty/jetty-util/6.1.26/jetty-util-6.1.26.jar"
/>
-        <pathElement location="${repository}/org/mortbay/jetty/servlet-api-2.5/6.1.14/servlet-api-2.5-6.1.14.jar"
/>
-        <pathElement location="${repository}/org/slf4j/slf4j-api/1.4.3/slf4j-api-1.4.3.jar"
/>
-        <pathElement location="${repository}/org/slf4j/slf4j-log4j12/1.4.3/slf4j-log4j12-1.4.3.jar"
/>
-        <!--pathElement location="${basedir}/../lib/jackson-0.9.2.jar" /-->
-        <pathElement location="${basedir}/../lib/accumulo-fate.jar" />
-        <pathElement location="${basedir}/../lib/accumulo-start.jar" />
-        <pathElement location="${basedir}/../lib/accumulo-trace.jar" />
-      </auxClasspath>
-      <sourcePath>
-        <pathElement location="${basedir}/core/src/main/java" />
-        <pathElement location="${basedir}/core/src/test/java" />
-        <pathElement location="${basedir}/fate/src/main/java" />
-        <pathElement location="${basedir}/fate/src/test/java" />
-        <pathElement location="${basedir}/server/src/main/java" />
-        <pathElement location="${basedir}/server/src/test/java" />
-        <pathElement location="${basedir}/start/src/main/java" />
-        <pathElement location="${basedir}/start/src/test/java" />
-        <pathElement location="${basedir}/test/src/main/java" />
-        <pathElement location="${basedir}/test/src/test/java" />
-        <pathElement location="${basedir}/trace/src/main/java" />
-        <pathElement location="${basedir}/trace/src/test/java" />
-        <pathElement location="${basedir}/examples/simple/src/main/java" />
-        <pathElement location="${basedir}/examples/simple/src/test/java" />
-      </sourcePath>
-      <class location="${basedir}/../lib/accumulo-core.jar" />
-      <class location="${basedir}/../lib/accumulo-fate.jar" />
-      <class location="${basedir}/../lib/accumulo-server.jar" />
-      <class location="${basedir}/../lib/accumulo-start.jar" />
-      <class location="${basedir}/../lib/accumulo-test.jar" />
-      <class location="${basedir}/../lib/accumulo-trace.jar" />
-      <class location="${basedir}/../lib/examples-simple.jar" />
-    </findbugs>
-  </target>
-
-</project>

http://git-wip-us.apache.org/repos/asf/accumulo/blob/8981ba04/contrib/run_findbugs.sh
----------------------------------------------------------------------
diff --git a/contrib/run_findbugs.sh b/contrib/run_findbugs.sh
deleted file mode 100755
index 0118712..0000000
--- a/contrib/run_findbugs.sh
+++ /dev/null
@@ -1,18 +0,0 @@
-#!/bin/sh
-
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements.  See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License.  You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-ant -buildfile findbugs_build.xml


Mime
View raw message