accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhava...@apache.org
Subject [02/12] git commit: Merge branch '1.5.1-SNAPSHOT' into 1.6.0-SNAPSHOT
Date Thu, 16 Jan 2014 20:16:51 GMT
Merge branch '1.5.1-SNAPSHOT' into 1.6.0-SNAPSHOT


Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/d5ebc7ab
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/d5ebc7ab
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/d5ebc7ab

Branch: refs/heads/master
Commit: d5ebc7ab5a1949a199cdb866f33eb8ba52a5cac3
Parents: d30a76f fe1348f
Author: John Vines <vines@apache.org>
Authored: Thu Jan 16 12:35:09 2014 -0500
Committer: John Vines <vines@apache.org>
Committed: Thu Jan 16 12:35:09 2014 -0500

----------------------------------------------------------------------
 .../java/org/apache/accumulo/tserver/log/TabletServerLogger.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/accumulo/blob/d5ebc7ab/server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java
----------------------------------------------------------------------
diff --cc server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java
index fb90757,0000000..14905af
mode 100644,000000..100644
--- a/server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java
+++ b/server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java
@@@ -1,430 -1,0 +1,430 @@@
 +/*
 + * Licensed to the Apache Software Foundation (ASF) under one or more
 + * contributor license agreements.  See the NOTICE file distributed with
 + * this work for additional information regarding copyright ownership.
 + * The ASF licenses this file to You under the Apache License, Version 2.0
 + * (the "License"); you may not use this file except in compliance with
 + * the License.  You may obtain a copy of the License at
 + *
 + *     http://www.apache.org/licenses/LICENSE-2.0
 + *
 + * Unless required by applicable law or agreed to in writing, software
 + * distributed under the License is distributed on an "AS IS" BASIS,
 + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 + * See the License for the specific language governing permissions and
 + * limitations under the License.
 + */
 +package org.apache.accumulo.tserver.log;
 +
 +import java.io.IOException;
 +import java.util.ArrayList;
 +import java.util.Collection;
 +import java.util.Collections;
 +import java.util.HashMap;
 +import java.util.List;
 +import java.util.Map;
 +import java.util.Map.Entry;
 +import java.util.Set;
 +import java.util.concurrent.atomic.AtomicInteger;
 +import java.util.concurrent.atomic.AtomicLong;
 +import java.util.concurrent.locks.ReadWriteLock;
 +import java.util.concurrent.locks.ReentrantReadWriteLock;
 +
 +import org.apache.accumulo.core.conf.Property;
 +import org.apache.accumulo.core.data.KeyExtent;
 +import org.apache.accumulo.core.data.Mutation;
 +import org.apache.accumulo.core.util.UtilWaitThread;
 +import org.apache.accumulo.server.fs.VolumeManager;
 +import org.apache.accumulo.tserver.Tablet;
 +import org.apache.accumulo.tserver.Tablet.CommitSession;
 +import org.apache.accumulo.tserver.TabletMutations;
 +import org.apache.accumulo.tserver.TabletServer;
 +import org.apache.accumulo.tserver.log.DfsLogger.LoggerOperation;
 +import org.apache.hadoop.fs.Path;
 +import org.apache.log4j.Logger;
 +
 +/**
 + * Central logging facility for the TServerInfo.
 + * 
 + * Forwards in-memory updates to remote logs, carefully writing the same data to every log,
while maintaining the maximum thread parallelism for greater
 + * performance. As new logs are used and minor compactions are performed, the metadata table
is kept up-to-date.
 + * 
 + */
 +public class TabletServerLogger {
 +  
 +  private static final Logger log = Logger.getLogger(TabletServerLogger.class);
 +  
 +  private final AtomicLong logSizeEstimate = new AtomicLong();
 +  private final long maxSize;
 +  
 +  private final TabletServer tserver;
 +  
 +  // The current log set: always updated to a new set with every change of loggers
 +  private final List<DfsLogger> loggers = new ArrayList<DfsLogger>();
 +  
 +  // The current generation of logSet.
 +  // Because multiple threads can be using a log set at one time, a log
 +  // failure is likely to affect multiple threads, who will all attempt to
 +  // create a new logSet. This will cause many unnecessary updates to the
 +  // metadata table.
 +  // We'll use this generational counter to determine if another thread has
 +  // already fetched a new logSet.
 +  private AtomicInteger logSetId = new AtomicInteger();
 +  
 +  // Use a ReadWriteLock to allow multiple threads to use the log set, but obtain a write
lock to change them
 +  private final ReentrantReadWriteLock logSetLock = new ReentrantReadWriteLock();
 +  
 +  private final AtomicInteger seqGen = new AtomicInteger();
 +  
 +  private static boolean enabled(Tablet tablet) {
 +    return tablet.getTableConfiguration().getBoolean(Property.TABLE_WALOG_ENABLED);
 +  }
 +  
 +  private static boolean enabled(CommitSession commitSession) {
 +    return enabled(commitSession.getTablet());
 +  }
 +  
 +  static private abstract class TestCallWithWriteLock {
 +    abstract boolean test();
 +    
 +    abstract void withWriteLock() throws IOException;
 +  }
 +  
 +  /**
 +   * Pattern taken from the documentation for ReentrantReadWriteLock
 +   * 
 +   * @param rwlock
 +   *          lock to use
 +   * @param code
 +   *          a test/work pair
 +   * @throws IOException
 +   */
 +  private static void testLockAndRun(final ReadWriteLock rwlock, TestCallWithWriteLock code)
throws IOException {
 +    // Get a read lock
 +    rwlock.readLock().lock();
 +    try {
 +      // does some condition exist that needs the write lock?
 +      if (code.test()) {
 +        // Yes, let go of the readlock
 +        rwlock.readLock().unlock();
 +        // Grab the write lock
 +        rwlock.writeLock().lock();
 +        try {
 +          // double-check the condition, since we let go of the lock
 +          if (code.test()) {
 +            // perform the work with with write lock held
 +            code.withWriteLock();
 +          }
 +        } finally {
 +          // regain the readlock
 +          rwlock.readLock().lock();
 +          // unlock the write lock
 +          rwlock.writeLock().unlock();
 +        }
 +      }
 +    } finally {
 +      // always let go of the lock
 +      rwlock.readLock().unlock();
 +    }
 +  }
 +  
 +  public TabletServerLogger(TabletServer tserver, long maxSize) {
 +    this.tserver = tserver;
 +    this.maxSize = maxSize;
 +  }
 +  
 +  private int initializeLoggers(final List<DfsLogger> copy) throws IOException {
 +    final int[] result = {-1};
 +    testLockAndRun(logSetLock, new TestCallWithWriteLock() {
 +      boolean test() {
 +        copy.clear();
 +        copy.addAll(loggers);
 +        if (!loggers.isEmpty())
 +          result[0] = logSetId.get();
 +        return loggers.isEmpty();
 +      }
 +      
 +      void withWriteLock() throws IOException {
 +        try {
 +          createLoggers();
 +          copy.clear();
 +          copy.addAll(loggers);
 +          if (copy.size() > 0)
 +            result[0] = logSetId.get();
 +          else
 +            result[0] = -1;
 +        } catch (IOException e) {
 +          log.error("Unable to create loggers", e);
 +        }
 +      }
 +    });
 +    return result[0];
 +  }
 +  
 +  public void getLogFiles(Set<String> loggersOut) {
 +    logSetLock.readLock().lock();
 +    try {
 +      for (DfsLogger logger : loggers) {
 +        loggersOut.add(logger.getFileName());
 +      }
 +    } finally {
 +      logSetLock.readLock().unlock();
 +    }
 +  }
 +  
 +  synchronized private void createLoggers() throws IOException {
 +    if (!logSetLock.isWriteLockedByCurrentThread()) {
 +      throw new IllegalStateException("createLoggers should be called with write lock held!");
 +    }
 +    
 +    if (loggers.size() != 0) {
 +      throw new IllegalStateException("createLoggers should not be called when loggers.size()
is " + loggers.size());
 +    }
 +    
 +    try {
 +      DfsLogger alog = new DfsLogger(tserver.getServerConfig());
 +      alog.open(tserver.getClientAddressString());
 +      loggers.add(alog);
 +      logSetId.incrementAndGet();
 +      return;
 +    } catch (Exception t) {
 +      throw new RuntimeException(t);
 +    }
 +  }
 +  
 +  public void resetLoggers() throws IOException {
 +    logSetLock.writeLock().lock();
 +    try {
 +      close();
 +    } finally {
 +      logSetLock.writeLock().unlock();
 +    }
 +  }
 +  
 +  synchronized private void close() throws IOException {
 +    if (!logSetLock.isWriteLockedByCurrentThread()) {
 +      throw new IllegalStateException("close should be called with write lock held!");
 +    }
 +    try {
 +      for (DfsLogger logger : loggers) {
 +        try {
 +          logger.close();
 +        } catch (DfsLogger.LogClosedException ex) {
 +          // ignore
 +        } catch (Throwable ex) {
-           log.error("Unable to cleanly close log " + logger.getFileName() + ": " + ex);
++          log.error("Unable to cleanly close log " + logger.getFileName() + ": " + ex, ex);
 +        }
 +      }
 +      loggers.clear();
 +      logSizeEstimate.set(0);
 +    } catch (Throwable t) {
 +      throw new IOException(t);
 +    }
 +  }
 +  
 +  interface Writer {
 +    LoggerOperation write(DfsLogger logger, int seq) throws Exception;
 +  }
 +  
 +  private int write(CommitSession commitSession, boolean mincFinish, Writer writer) throws
IOException {
 +    List<CommitSession> sessions = Collections.singletonList(commitSession);
 +    return write(sessions, mincFinish, writer);
 +  }
 +  
 +  private int write(Collection<CommitSession> sessions, boolean mincFinish, Writer
writer) throws IOException {
 +    // Work very hard not to lock this during calls to the outside world
 +    int currentLogSet = logSetId.get();
 +    
 +    int seq = -1;
 +    
 +    int attempt = 0;
 +    boolean success = false;
 +    while (!success) {
 +      try {
 +        // get a reference to the loggers that no other thread can touch
 +        ArrayList<DfsLogger> copy = new ArrayList<DfsLogger>();
 +        currentLogSet = initializeLoggers(copy);
 +        
 +        // add the logger to the log set for the memory in the tablet,
 +        // update the metadata table if we've never used this tablet
 +        
 +        if (currentLogSet == logSetId.get()) {
 +          for (CommitSession commitSession : sessions) {
 +            if (commitSession.beginUpdatingLogsUsed(copy, mincFinish)) {
 +              try {
 +                // Scribble out a tablet definition and then write to the metadata table
 +                defineTablet(commitSession);
 +                if (currentLogSet == logSetId.get())
 +                  tserver.addLoggersToMetadata(copy, commitSession.getExtent(), commitSession.getLogId());
 +              } finally {
 +                commitSession.finishUpdatingLogsUsed();
 +              }
 +            }
 +          }
 +        }
 +        
 +        // Make sure that the logs haven't changed out from underneath our copy
 +        if (currentLogSet == logSetId.get()) {
 +          
 +          // write the mutation to the logs
 +          seq = seqGen.incrementAndGet();
 +          if (seq < 0)
 +            throw new RuntimeException("Logger sequence generator wrapped!  Onos!!!11!eleven");
 +          ArrayList<LoggerOperation> queuedOperations = new ArrayList<LoggerOperation>(copy.size());
 +          for (DfsLogger wal : copy) {
 +            LoggerOperation lop = writer.write(wal, seq);
 +            if (lop != null)
 +              queuedOperations.add(lop);
 +          }
 +          
 +          for (LoggerOperation lop : queuedOperations) {
 +            lop.await();
 +          }
 +          
 +          // double-check: did the log set change?
 +          success = (currentLogSet == logSetId.get());
 +        }
 +      } catch (DfsLogger.LogClosedException ex) {
 +        log.debug("Logs closed while writing, retrying " + (attempt + 1));
 +      } catch (Exception t) {
 +        log.error("Unexpected error writing to log, retrying attempt " + (attempt + 1),
t);
 +        UtilWaitThread.sleep(100);
 +      } finally {
 +        attempt++;
 +      }
 +      // Some sort of write failure occurred. Grab the write lock and reset the logs.
 +      // But since multiple threads will attempt it, only attempt the reset when
 +      // the logs haven't changed.
 +      final int finalCurrent = currentLogSet;
 +      if (!success) {
 +        testLockAndRun(logSetLock, new TestCallWithWriteLock() {
 +          
 +          @Override
 +          boolean test() {
 +            return finalCurrent == logSetId.get();
 +          }
 +          
 +          @Override
 +          void withWriteLock() throws IOException {
 +            close();
 +          }
 +        });
 +      }
 +    }
 +    // if the log gets too big, reset it .. grab the write lock first
 +    logSizeEstimate.addAndGet(4 * 3); // event, tid, seq overhead
 +    testLockAndRun(logSetLock, new TestCallWithWriteLock() {
 +      boolean test() {
 +        return logSizeEstimate.get() > maxSize;
 +      }
 +      
 +      void withWriteLock() throws IOException {
 +        close();
 +      }
 +    });
 +    return seq;
 +  }
 +  
 +  public int defineTablet(final CommitSession commitSession) throws IOException {
 +    // scribble this into the metadata tablet, too.
 +    if (!enabled(commitSession))
 +      return -1;
 +    return write(commitSession, false, new Writer() {
 +      @Override
 +      public LoggerOperation write(DfsLogger logger, int ignored) throws Exception {
 +        logger.defineTablet(commitSession.getWALogSeq(), commitSession.getLogId(), commitSession.getExtent());
 +        return null;
 +      }
 +    });
 +  }
 +  
 +  public int log(final CommitSession commitSession, final int tabletSeq, final Mutation
m) throws IOException {
 +    if (!enabled(commitSession))
 +      return -1;
 +    int seq = write(commitSession, false, new Writer() {
 +      @Override
 +      public LoggerOperation write(DfsLogger logger, int ignored) throws Exception {
 +        return logger.log(tabletSeq, commitSession.getLogId(), m);
 +      }
 +    });
 +    logSizeEstimate.addAndGet(m.numBytes());
 +    return seq;
 +  }
 +  
 +  public int logManyTablets(Map<CommitSession,List<Mutation>> mutations) throws
IOException {
 +    
 +    final Map<CommitSession,List<Mutation>> loggables = new HashMap<CommitSession,List<Mutation>>(mutations);
 +    for (CommitSession t : mutations.keySet()) {
 +      if (!enabled(t))
 +        loggables.remove(t);
 +    }
 +    if (loggables.size() == 0)
 +      return -1;
 +    
 +    int seq = write(loggables.keySet(), false, new Writer() {
 +      @Override
 +      public LoggerOperation write(DfsLogger logger, int ignored) throws Exception {
 +        List<TabletMutations> copy = new ArrayList<TabletMutations>(loggables.size());
 +        for (Entry<CommitSession,List<Mutation>> entry : loggables.entrySet())
{
 +          CommitSession cs = entry.getKey();
 +          copy.add(new TabletMutations(cs.getLogId(), cs.getWALogSeq(), entry.getValue()));
 +        }
 +        return logger.logManyTablets(copy);
 +      }
 +    });
 +    for (List<Mutation> entry : loggables.values()) {
 +      if (entry.size() < 1)
 +        throw new IllegalArgumentException("logManyTablets: logging empty mutation list");
 +      for (Mutation m : entry) {
 +        logSizeEstimate.addAndGet(m.numBytes());
 +      }
 +    }
 +    return seq;
 +  }
 +  
 +  public void minorCompactionFinished(final CommitSession commitSession, final String fullyQualifiedFileName,
final int walogSeq) throws IOException {
 +    
 +    if (!enabled(commitSession))
 +      return;
 +    
 +    long t1 = System.currentTimeMillis();
 +    
 +    int seq = write(commitSession, true, new Writer() {
 +      @Override
 +      public LoggerOperation write(DfsLogger logger, int ignored) throws Exception {
 +        logger.minorCompactionFinished(walogSeq, commitSession.getLogId(), fullyQualifiedFileName).await();
 +        return null;
 +      }
 +    });
 +    
 +    long t2 = System.currentTimeMillis();
 +    
 +    log.debug(" wrote MinC finish  " + seq + ": writeTime:" + (t2 - t1) + "ms ");
 +  }
 +  
 +  public int minorCompactionStarted(final CommitSession commitSession, final int seq, final
String fullyQualifiedFileName) throws IOException {
 +    if (!enabled(commitSession))
 +      return -1;
 +    write(commitSession, false, new Writer() {
 +      @Override
 +      public LoggerOperation write(DfsLogger logger, int ignored) throws Exception {
 +        logger.minorCompactionStarted(seq, commitSession.getLogId(), fullyQualifiedFileName).await();
 +        return null;
 +      }
 +    });
 +    return seq;
 +  }
 +  
 +  public void recover(VolumeManager fs, Tablet tablet, List<Path> logs, Set<String>
tabletFiles, MutationReceiver mr) throws IOException {
 +    if (!enabled(tablet))
 +      return;
 +    try {
 +      SortedLogRecovery recovery = new SortedLogRecovery(fs);
 +      KeyExtent extent = tablet.getExtent();
 +      recovery.recover(extent, logs, tabletFiles, mr);
 +    } catch (Exception e) {
 +      throw new IOException(e);
 +    }
 +  }
 +  
 +}


Mime
View raw message