Return-Path: X-Original-To: apmail-accumulo-commits-archive@www.apache.org Delivered-To: apmail-accumulo-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E26CF108CB for ; Sun, 24 Nov 2013 00:33:32 +0000 (UTC) Received: (qmail 92456 invoked by uid 500); 24 Nov 2013 00:33:32 -0000 Delivered-To: apmail-accumulo-commits-archive@accumulo.apache.org Received: (qmail 92314 invoked by uid 500); 24 Nov 2013 00:33:32 -0000 Mailing-List: contact commits-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list commits@accumulo.apache.org Received: (qmail 92291 invoked by uid 99); 24 Nov 2013 00:33:32 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Nov 2013 00:33:32 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 5E46090403C; Sun, 24 Nov 2013 00:33:32 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: elserj@apache.org To: commits@accumulo.apache.org Date: Sun, 24 Nov 2013 00:33:34 -0000 Message-Id: <65f12ad55d8e4ed8a7e97899086bf769@git.apache.org> In-Reply-To: <449e651f9ade4e8fa564570029299af0@git.apache.org> References: <449e651f9ade4e8fa564570029299af0@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [03/31] git commit: ACCUMULO-1914 make WALog cleanup after recovery an atomic mutation ACCUMULO-1914 make WALog cleanup after recovery an atomic mutation Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/2640ea9d Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/2640ea9d Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/2640ea9d Branch: refs/heads/master Commit: 2640ea9d926f771274ed10efd23e7400a483f6c0 Parents: 3f633bf Author: Eric Newton Authored: Thu Nov 21 12:19:01 2013 -0500 Committer: Eric Newton Committed: Thu Nov 21 12:55:51 2013 -0500 ---------------------------------------------------------------------- .../org/apache/accumulo/server/util/MetadataTable.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/accumulo/blob/2640ea9d/src/server/src/main/java/org/apache/accumulo/server/util/MetadataTable.java ---------------------------------------------------------------------- diff --git a/src/server/src/main/java/org/apache/accumulo/server/util/MetadataTable.java b/src/server/src/main/java/org/apache/accumulo/server/util/MetadataTable.java index 9c4eebf..a9b72e0 100644 --- a/src/server/src/main/java/org/apache/accumulo/server/util/MetadataTable.java +++ b/src/server/src/main/java/org/apache/accumulo/server/util/MetadataTable.java @@ -991,8 +991,8 @@ public class MetadataTable extends org.apache.accumulo.core.util.MetadataTable { } public static void removeUnusedWALEntries(KeyExtent extent, List logEntries, ZooLock zooLock) { - for (LogEntry entry : logEntries) { - if (entry.extent.equals(Constants.ROOT_TABLET_EXTENT)) { + if (extent.equals(Constants.ROOT_TABLET_EXTENT)) { + for (LogEntry entry : logEntries) { String root = getZookeeperLogLocation(); while (true) { try { @@ -1005,11 +1005,13 @@ public class MetadataTable extends org.apache.accumulo.core.util.MetadataTable { } UtilWaitThread.sleep(1000); } + } } else { - Mutation m = new Mutation(entry.extent.getMetadataEntry()); - m.putDelete(Constants.METADATA_LOG_COLUMN_FAMILY, new Text(entry.server + "/" + entry.filename)); + Mutation m = new Mutation(extent.getMetadataEntry()); + for (LogEntry entry : logEntries) { + m.putDelete(Constants.METADATA_LOG_COLUMN_FAMILY, new Text(entry.server + "/" + entry.filename)); + } update(SecurityConstants.getSystemCredentials(), zooLock, m); - } } }