Return-Path: X-Original-To: apmail-accumulo-commits-archive@www.apache.org Delivered-To: apmail-accumulo-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E1A3105D4 for ; Thu, 17 Oct 2013 16:50:01 +0000 (UTC) Received: (qmail 60159 invoked by uid 500); 17 Oct 2013 16:50:01 -0000 Delivered-To: apmail-accumulo-commits-archive@accumulo.apache.org Received: (qmail 60036 invoked by uid 500); 17 Oct 2013 16:50:01 -0000 Mailing-List: contact commits-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list commits@accumulo.apache.org Received: (qmail 59853 invoked by uid 99); 17 Oct 2013 16:49:54 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Oct 2013 16:49:54 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 4F40A9171F2; Thu, 17 Oct 2013 16:49:54 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: elserj@apache.org To: commits@accumulo.apache.org Date: Thu, 17 Oct 2013 16:49:55 -0000 Message-Id: In-Reply-To: <3b690823a5584867a6c4e631a3bbeb66@git.apache.org> References: <3b690823a5584867a6c4e631a3bbeb66@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/2] git commit: ACCUMULO-1637 Lifting the ticket message into its own string constant ACCUMULO-1637 Lifting the ticket message into its own string constant Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/685cc4a7 Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/685cc4a7 Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/685cc4a7 Branch: refs/heads/1.5.1-SNAPSHOT Commit: 685cc4a70d87fd7eda56538fb381a8347b4e56e3 Parents: d1243aa Author: Josh Elser Authored: Thu Oct 17 12:48:57 2013 -0400 Committer: Josh Elser Committed: Thu Oct 17 12:48:57 2013 -0400 ---------------------------------------------------------------------- .../org/apache/accumulo/server/tabletserver/TabletServer.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/accumulo/blob/685cc4a7/server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java ---------------------------------------------------------------------- diff --git a/server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java b/server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java index 137d3b1..ea30694 100644 --- a/server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java +++ b/server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java @@ -3245,6 +3245,7 @@ public class TabletServer extends AbstractMetricsImpl implements org.apache.accu private static void ensureHdfsSyncIsEnabled(FileSystem fs) { if (fs instanceof DistributedFileSystem) { final String DFS_DURABLE_SYNC = "dfs.durable.sync", DFS_SUPPORT_APPEND = "dfs.support.append"; + final String ticketMessage = "See ACCUMULO-623 and ACCUMULO-1637 for more details."; // Check to make sure that we have proper defaults configured try { // If the default is off (0.20.205.x or 1.0.x) @@ -3257,7 +3258,7 @@ public class TabletServer extends AbstractMetricsImpl implements org.apache.accu if (!dfsSupportAppendDefaultValue) { // See if the user did the correct override if (!fs.getConf().getBoolean(DFSConfigKeys.DFS_SUPPORT_APPEND_KEY, false)) { - log.fatal("Accumulo requires that dfs.support.append to true. See ACCUMULO-623 and ACCUMULO-1637 for more details."); + log.fatal("Accumulo requires that dfs.support.append to true. " + ticketMessage); System.exit(-1); } } @@ -3265,13 +3266,13 @@ public class TabletServer extends AbstractMetricsImpl implements org.apache.accu // If we can't find DFSConfigKeys.DFS_SUPPORT_APPEND_DEFAULT, the user is running // 1.1.x or 1.2.x. This is ok, though, as, by default, these versions have append/sync enabled. } catch (Exception e) { - log.warn("Error while checking for " + DFS_SUPPORT_APPEND + ". The user should ensure that Hadoop is configured to properly supports append and sync. See ACCUMULO-623 and ACCUMULO-1637 for more details.", e); + log.warn("Error while checking for " + DFS_SUPPORT_APPEND + ". The user should ensure that Hadoop is configured to properly supports append and sync. " + ticketMessage, e); } // If either of these parameters are configured to be false, fail. // This is a sign that someone is writing bad configuration. if (!fs.getConf().getBoolean(DFS_SUPPORT_APPEND, true) || !fs.getConf().getBoolean(DFS_DURABLE_SYNC, true)) { - log.fatal("Accumulo requires that " + DFS_SUPPORT_APPEND + " and " + DFS_DURABLE_SYNC + " not be configured as false. See ACCUMULO-623 and ACCUMULO-1637 for more details."); + log.fatal("Accumulo requires that " + DFS_SUPPORT_APPEND + " and " + DFS_DURABLE_SYNC + " not be configured as false. " + ticketMessage); System.exit(-1); }