accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From els...@apache.org
Subject [2/2] git commit: ACCUMULO-1637 Lifting the ticket message into its own string constant
Date Thu, 17 Oct 2013 16:49:55 GMT
ACCUMULO-1637 Lifting the ticket message into its own string constant


Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/685cc4a7
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/685cc4a7
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/685cc4a7

Branch: refs/heads/1.5.1-SNAPSHOT
Commit: 685cc4a70d87fd7eda56538fb381a8347b4e56e3
Parents: d1243aa
Author: Josh Elser <elserj@apache.org>
Authored: Thu Oct 17 12:48:57 2013 -0400
Committer: Josh Elser <elserj@apache.org>
Committed: Thu Oct 17 12:48:57 2013 -0400

----------------------------------------------------------------------
 .../org/apache/accumulo/server/tabletserver/TabletServer.java | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/accumulo/blob/685cc4a7/server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java
----------------------------------------------------------------------
diff --git a/server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java
b/server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java
index 137d3b1..ea30694 100644
--- a/server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java
+++ b/server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java
@@ -3245,6 +3245,7 @@ public class TabletServer extends AbstractMetricsImpl implements org.apache.accu
   private static void ensureHdfsSyncIsEnabled(FileSystem fs) {
     if (fs instanceof DistributedFileSystem) {
       final String DFS_DURABLE_SYNC = "dfs.durable.sync", DFS_SUPPORT_APPEND = "dfs.support.append";
+      final String ticketMessage = "See ACCUMULO-623 and ACCUMULO-1637 for more details.";
       // Check to make sure that we have proper defaults configured
       try {
         // If the default is off (0.20.205.x or 1.0.x)
@@ -3257,7 +3258,7 @@ public class TabletServer extends AbstractMetricsImpl implements org.apache.accu
         if (!dfsSupportAppendDefaultValue) {
           // See if the user did the correct override
           if (!fs.getConf().getBoolean(DFSConfigKeys.DFS_SUPPORT_APPEND_KEY, false)) {
-            log.fatal("Accumulo requires that dfs.support.append to true. See ACCUMULO-623
and ACCUMULO-1637 for more details.");
+            log.fatal("Accumulo requires that dfs.support.append to true. " + ticketMessage);
             System.exit(-1);
           }
         }
@@ -3265,13 +3266,13 @@ public class TabletServer extends AbstractMetricsImpl implements org.apache.accu
         // If we can't find DFSConfigKeys.DFS_SUPPORT_APPEND_DEFAULT, the user is running
         // 1.1.x or 1.2.x. This is ok, though, as, by default, these versions have append/sync
enabled.
       } catch (Exception e) {
-        log.warn("Error while checking for " + DFS_SUPPORT_APPEND + ". The user should ensure
that Hadoop is configured to properly supports append and sync. See ACCUMULO-623 and ACCUMULO-1637
for more details.", e);
+        log.warn("Error while checking for " + DFS_SUPPORT_APPEND + ". The user should ensure
that Hadoop is configured to properly supports append and sync. " + ticketMessage, e);
       }
       
       // If either of these parameters are configured to be false, fail.
       // This is a sign that someone is writing bad configuration.
       if (!fs.getConf().getBoolean(DFS_SUPPORT_APPEND, true) || !fs.getConf().getBoolean(DFS_DURABLE_SYNC,
true)) {
-        log.fatal("Accumulo requires that " + DFS_SUPPORT_APPEND + " and " + DFS_DURABLE_SYNC
+ " not be configured as false. See ACCUMULO-623 and ACCUMULO-1637 for more details.");
+        log.fatal("Accumulo requires that " + DFS_SUPPORT_APPEND + " and " + DFS_DURABLE_SYNC
+ " not be configured as false. " + ticketMessage);
         System.exit(-1);
       }
       


Mime
View raw message