accumulo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ktur...@apache.org
Subject svn commit: r1457888 - in /accumulo/branches/1.5: core/src/main/java/org/apache/accumulo/core/client/mock/ core/src/main/java/org/apache/accumulo/core/iterators/ server/src/main/java/org/apache/accumulo/server/master/ server/src/main/java/org/apache/ac...
Date Mon, 18 Mar 2013 17:35:31 GMT
Author: kturner
Date: Mon Mar 18 17:35:30 2013
New Revision: 1457888

URL: http://svn.apache.org/r1457888
Log:
ACCUMULO-972 removed some TODOs that are no longer relevant

Modified:
    accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java
    accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java
    accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/master/Master.java
    accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/master/TServerLockWatcher.java
    accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/tabletserver/Tablet.java
    accumulo/branches/1.5/test/src/main/java/org/apache/accumulo/test/functional/SparseColumnFamilyTest.java
    accumulo/branches/1.5/test/src/main/java/org/apache/accumulo/test/randomwalk/Module.java

Modified: accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java
URL: http://svn.apache.org/viewvc/accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java?rev=1457888&r1=1457887&r2=1457888&view=diff
==============================================================================
--- accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java
(original)
+++ accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java
Mon Mar 18 17:35:30 2013
@@ -126,14 +126,8 @@ public class MockInstanceOperations impl
     return new ArrayList<ActiveCompaction>();
   }
   
-  /*
-   * (non-Javadoc)
-   * 
-   * @see org.apache.accumulo.core.client.admin.InstanceOperations#ping(java.lang.String)
-   */
   @Override
   public void ping(String tserver) throws AccumuloException {
-    // TODO Auto-generated method stub
-    
+
   }
 }

Modified: accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java
URL: http://svn.apache.org/viewvc/accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java?rev=1457888&r1=1457887&r2=1457888&view=diff
==============================================================================
--- accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java
(original)
+++ accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java
Mon Mar 18 17:35:30 2013
@@ -84,7 +84,6 @@ public class ColumnFamilyCounter impleme
   
   @Override
   public SortedKeyValueIterator<Key,Value> deepCopy(IteratorEnvironment env) {
-    // TODO Auto-generated method stub
     return null;
   }
   

Modified: accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/master/Master.java
URL: http://svn.apache.org/viewvc/accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/master/Master.java?rev=1457888&r1=1457887&r2=1457888&view=diff
==============================================================================
--- accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/master/Master.java
(original)
+++ accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/master/Master.java
Mon Mar 18 17:35:30 2013
@@ -138,7 +138,6 @@ import org.apache.accumulo.server.master
 import org.apache.accumulo.server.master.tableOps.TraceRepo;
 import org.apache.accumulo.server.master.tserverOps.ShutdownTServer;
 import org.apache.accumulo.server.monitor.Monitor;
-import org.apache.accumulo.server.monitor.util.Table;
 import org.apache.accumulo.server.security.AuditedSecurityOperation;
 import org.apache.accumulo.server.security.SecurityConstants;
 import org.apache.accumulo.server.security.SecurityOperation;
@@ -2007,7 +2006,6 @@ public class Master implements LiveTServ
           if (connection == null)
             throw new IOException("No connection to " + server);
           TabletServerStatus status = connection.getTableMap();
-          // TODO maybe remove from bad servers
           result.put(server, status);
         } finally {
           t.setName(oldName);

Modified: accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/master/TServerLockWatcher.java
URL: http://svn.apache.org/viewvc/accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/master/TServerLockWatcher.java?rev=1457888&r1=1457887&r2=1457888&view=diff
==============================================================================
--- accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/master/TServerLockWatcher.java
(original)
+++ accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/master/TServerLockWatcher.java
Mon Mar 18 17:35:30 2013
@@ -38,9 +38,6 @@ class TServerLockWatcher implements Asyn
   public void lostLock(LockLossReason reason) {}
   
   @Override
-  public void unableToMonitorLockNode(Throwable e) {
-    // TODO Auto-generated method stub
-    
-  }
+  public void unableToMonitorLockNode(Throwable e) {}
   
 }

Modified: accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/tabletserver/Tablet.java
URL: http://svn.apache.org/viewvc/accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/tabletserver/Tablet.java?rev=1457888&r1=1457887&r2=1457888&view=diff
==============================================================================
--- accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/tabletserver/Tablet.java
(original)
+++ accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/tabletserver/Tablet.java
Mon Mar 18 17:35:30 2013
@@ -708,14 +708,6 @@ public class Tablet {
         
       }
       
-      // TODO I do not think the case below is needed anymore
-      /*
-       * if(!fs.exists(new Path(bulkDir, Constants.BULK_LOAD_IN_PROGRESS))){ DataFileValue
zero = new DataFileValue(0, 0);
-       * MetadataTable.replaceDatafiles(extent, abs2rel(paths.keySet()), new HashSet<String>(),
"junk", null, zero, SecurityConstants.getSystemCredentials(),
-       * tabletServer.getClientAddressString(), lastLocation, tabletServer.getLock(), false);
throw new
-       * IOException("Processing file does not exist, aborting bulk import "+extent+" "+bulkDir);
}
-       */
-      
       synchronized (Tablet.this) {
         for (Entry<Path,DataFileValue> tpath : paths.entrySet()) {
           if (datafileSizes.containsKey(tpath.getKey())) {

Modified: accumulo/branches/1.5/test/src/main/java/org/apache/accumulo/test/functional/SparseColumnFamilyTest.java
URL: http://svn.apache.org/viewvc/accumulo/branches/1.5/test/src/main/java/org/apache/accumulo/test/functional/SparseColumnFamilyTest.java?rev=1457888&r1=1457887&r2=1457888&view=diff
==============================================================================
--- accumulo/branches/1.5/test/src/main/java/org/apache/accumulo/test/functional/SparseColumnFamilyTest.java
(original)
+++ accumulo/branches/1.5/test/src/main/java/org/apache/accumulo/test/functional/SparseColumnFamilyTest.java
Mon Mar 18 17:35:30 2013
@@ -111,9 +111,6 @@ public class SparseColumnFamilyTest exte
   }
 
   @Override
-  public void cleanup() throws Exception {
-    // TODO Auto-generated method stub
-    
-  }
+  public void cleanup() throws Exception {}
   
 }

Modified: accumulo/branches/1.5/test/src/main/java/org/apache/accumulo/test/randomwalk/Module.java
URL: http://svn.apache.org/viewvc/accumulo/branches/1.5/test/src/main/java/org/apache/accumulo/test/randomwalk/Module.java?rev=1457888&r1=1457887&r2=1457888&view=diff
==============================================================================
--- accumulo/branches/1.5/test/src/main/java/org/apache/accumulo/test/randomwalk/Module.java
(original)
+++ accumulo/branches/1.5/test/src/main/java/org/apache/accumulo/test/randomwalk/Module.java
Mon Mar 18 17:35:30 2013
@@ -340,7 +340,6 @@ public class Module extends Node {
       try {
         timer.join();
       } catch (InterruptedException e) {
-        // TODO Auto-generated catch block
         e.printStackTrace();
       }
     }



Mime
View raw message