abdera-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Berry <chriswbe...@gmail.com>
Subject Re: HTTP-GET-Problem with Abdera-Client 0.3.0.
Date Tue, 11 Dec 2007 15:40:03 GMT
Personally, I like option 1.  I suspect others will eventually need  
this as well.
You should consider making it a patch and submitting it in JIRA.

On Dec 11, 2007, at 9:35 AM, herbert wrote:

>
> Hi Chris!
>
> My solution would be adding a property followRedirects to the class
> RequestOptions.
>
> Next change would be in the method createMethod() of the class  
> MethodHelper.
> After creation of the concrete HTTP-Method I would insert the  
> following
> line:
> httpMethod.setFollowRedirects(options.isFollowRedirect());
>
> (Or another version, introducing a property revertRedirectSetting  
> to the
> class
> RequestOptions. And then in createMethod():
>
> if (options.isRevertRedirectSetting()) {
>   httpMethod.setFollowRedirects(!httpMethod.getFollowRedirects());
> })
>
> Dunno, if these are generic approaches, that are interesting for  
> others?
>
> Regards, Herbert
>
>
> Chris Berry wrote:
>>
>> Herbert,
>> I think you're correct. I just *assumed* that this was a part of
>> HttpMethodParams. But I cannot see it there either (at least with a
>> cursory look)
>>
>> I think you should simply make the enclosed HttpClient protected in
>> AbderaClient.  And then extend AbderaClient locally with
>> MyAbderaClient. This is probably a better solution than actually
>> adding an accessor for HttpClient in AbderaClient, which seems a bit
>> promiscuous to me.
>> Cheers,
>> -- Chris 
>>
>>
>
> -- 
> View this message in context: http://www.nabble.com/HTTP-GET- 
> Problem-with-Abdera-Client-0.3.0.-tp14212795p14276334.html
> Sent from the abdera-user mailing list archive at Nabble.com.
>

S'all good  ---   chriswberry at gmail dot com




Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message