abdera-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neale Upstone <ne...@whirlwindmatch.com>
Subject Re: In examples, 404 etc should be HttpServletResponse.SC_NOT_FOUND, etc
Date Thu, 01 Nov 2007 17:49:54 GMT
Will do when I find a bit of time.

Disagree on the "they're well known argument from Brian, as they're 
not.  200, 302 and 500 are all that I'd have stood a chance at in a 
multiple choice test, as I don't usually write stuff at that low a 
level.  And, it's an example, so should be aimed at the lowest in the 
ecosystem, not at HTTP gurus (IMHO).

Cheers,

Neale



James M Snell wrote:
> Would you be interested in submitting a patch to jira?
>
> - James
>
> Neale wrote:
>   
>> Hi,
>>
>> Little gripe, but other than that, things are progressing nicely here.
>>
>> In the ProviderImpl example (and possibly elsewhere), could you
>> standardise on using the constants from HttpServletResponse (or an
>> internal set that documents the specific meaning of each response code
>> related to Atom).
>>
>> For example, it's much easier to ensure we're handing errors correctly
>> when the code we've used as our basis reads:
>>            return new
>> EmptyResponseContext(HttpServletResponse.SC_NOT_FOUND);
>> instead of
>>            return new EmptyResponseContext(404);
>>
>> Cheers,
>>
>> Neale
>>
>>
>>
>>     

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message