abdera-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James M Snell <jasn...@gmail.com>
Subject Re: In examples, 404 etc should be HttpServletResponse.SC_NOT_FOUND, etc
Date Thu, 01 Nov 2007 17:21:30 GMT
Would you be interested in submitting a patch to jira?

- James

Neale wrote:
> Hi,
> 
> Little gripe, but other than that, things are progressing nicely here.
> 
> In the ProviderImpl example (and possibly elsewhere), could you
> standardise on using the constants from HttpServletResponse (or an
> internal set that documents the specific meaning of each response code
> related to Atom).
> 
> For example, it's much easier to ensure we're handing errors correctly
> when the code we've used as our basis reads:
>            return new
> EmptyResponseContext(HttpServletResponse.SC_NOT_FOUND);
> instead of
>            return new EmptyResponseContext(404);
> 
> Cheers,
> 
> Neale
> 
> 
> 

Mime
View raw message