abdera-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Garrett Rooney" <roo...@electricjellyfish.net>
Subject Re: Failing tests (was Re: <content src=>)
Date Wed, 09 Aug 2006 14:11:27 GMT
On 8/8/06, Ugo Cei <ugo.cei@gmail.com> wrote:
>
> On Aug 8, 2006, at 8:04 PM, Garrett Rooney wrote:
>
> > I'd say that a more correct change would be to return a copy of the
> > options, instead of a reference to the default one, but that's just
> > me.  It seems like modifying the ParserOptions you get from
> > getDefaultParserOptions shouldn't change the defaults for everyone
> > else.
>
> In this case, better leave the test as is and not apply my patch,
> since it's effect would be to hide what is effectively a bug.
>
> Besides, I forgot to remove some System.out.print statements before
> doing the diff.

For those not watching the commits list, these failing tests should be
fixed now.

-garrett

Mime
View raw message