abdera-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Garrett Rooney" <roo...@electricjellyfish.net>
Subject Re: Failing tests (was Re: <content src=>)
Date Tue, 08 Aug 2006 18:05:55 GMT
On 8/8/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:

> Ahh, recent change, I was looking at an older working copy.
>
> I'd say that a more correct change would be to return a copy of the
> options, instead of a reference to the default one, but that's just
> me.  It seems like modifying the ParserOptions you get from
> getDefaultParserOptions shouldn't change the defaults for everyone
> else.

Also, the fact that FOMParser includes a lazily initialized variable
like that is kind of disconcerting from a thread safety manner,
considering that it's likely to be accessed via Parser.INSTANCE...

-garrett

Mime
View raw message