abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ant elder <antel...@apache.org>
Subject Re: Eclipse Formatter Template
Date Sat, 05 Jun 2010 07:43:41 GMT
I've updated the formatter template at
https://svn.apache.org/repos/asf/abdera/etc/abdera-eclipse-formatter.xml
and reformatted all the code based on that. Still not quite perfect
but thats as best as i could find and at least all the code is
consistent now. If anyone wants to tweak it or can find better
formatter settings please just jump in an update it.

   ...ant

On Sun, May 23, 2010 at 7:15 AM, ant elder <antelder@apache.org> wrote:
> Yes. I'd set never join lines so the formatter template doesn't mess
> things up where someone has tried to intentionally lay things out how
> they like, but i guess thats not going to work for this initial
> reformat. Anyway, if no one says to hold off then I'll commit the
> reformat based on this with
> Never join line unchecked tonight.
>
>   ...ant
>
>
> On Sat, May 22, 2010 at 7:00 PM, ck <ch.ko123@googlemail.com> wrote:
>> Hi Ant,
>>
>> seems unchecking "Line Wrapping" -> "Never join lines" does the job
>>
>> 2010/5/19 ant elder <antelder@apache.org>:
>>> Unfortunately the current formatter template doesn't seem quite
>>> perfect yet. I did a global format but things like:
>>>
>>>  public AbderaClient(
>>>    Abdera abdera,
>>>    String useragent) {
>>>      this(abdera,useragent,initCache(abdera));
>>>  }
>>>
>>> turn in to
>>>
>>>    public AbderaClient(
>>>                        Abdera abdera,
>>>                        String useragent) {
>>>        this(abdera, useragent, initCache(abdera));
>>>    }
>>>
>>> but what i'd really like would be
>>>
>>>    public AbderaClient(Abdera abdera, String useragent) {
>>>        this(abdera, useragent, initCache(abdera));
>>>    }
>>>
>>> so i'd like to try tweaking the formatter a bit more before committing
>>> a reformat. If anyone has any better settings please do commit or
>>> share :)
>>>
>>>   ...ant
>>>
>>>
>>> On Tue, May 18, 2010 at 7:04 PM, ck <ch.ko123@googlemail.com> wrote:
>>>> +1
>>>>
>>>> 2010/5/18 ant elder <antelder@apache.org>:
>>>>> How about doing the global format tomorrow evening (GMT)? Would that
>>>>> fit in, remember that if anyone has uncommitted changes this is likely
>>>>> to cause conflicts making it hard to merge in updates afterwards.
>>>>>
>>>>>   ...ant
>>>>>
>>>>> On Sun, May 16, 2010 at 11:14 AM, ck <ch.ko123@googlemail.com>
wrote:
>>>>>> looks good to me.
>>>>>>
>>>>>> Would be great if you could you send a short notice before
>>>>>> reformatting the trunk.
>>>>>>
>>>>>>>
>>>>>>> I've added an eclipse formatter template at:
>>>>>>>
>>>>>>>    https://svn.apache.org/repos/asf/abdera/etc
>>>>>>>
>>>>>>> Feel free to hack it about, the main things in it (which reflect
my
>>>>>>> preferences) are:
>>>>>>> - uses spaces not tabs
>>>>>>> - uses braces always on the same line
>>>>>>> - doesn't format comments
>>>>>>> - never joins lines
>>>>>>>
>>>>>>> Once we have something everyone is happy with should we do a
global
>>>>>>> format of the entire source tree to get it all into a consistent
>>>>>>> state?
>>>>>>>
>>>>>>>   ...ant
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

Mime
View raw message