Return-Path: Delivered-To: apmail-abdera-dev-archive@www.apache.org Received: (qmail 52505 invoked from network); 11 May 2010 21:27:21 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 11 May 2010 21:27:21 -0000 Received: (qmail 27894 invoked by uid 500); 11 May 2010 21:27:21 -0000 Delivered-To: apmail-abdera-dev-archive@abdera.apache.org Received: (qmail 27854 invoked by uid 500); 11 May 2010 21:27:20 -0000 Mailing-List: contact dev-help@abdera.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@abdera.apache.org Delivered-To: mailing list dev@abdera.apache.org Received: (qmail 27846 invoked by uid 99); 11 May 2010 21:27:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 May 2010 21:27:20 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of ch.ko123@googlemail.com designates 209.85.219.222 as permitted sender) Received: from [209.85.219.222] (HELO mail-ew0-f222.google.com) (209.85.219.222) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 May 2010 21:27:14 +0000 Received: by ewy22 with SMTP id 22so1665195ewy.17 for ; Tue, 11 May 2010 14:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:content-type; bh=bBEa4901HifdyA1PEwrHG7ZFf73tJvinopbEPbQBq6o=; b=AumsT47Vbg27CVjlzS/epdSAdrmtyYJy79UT1AJvx6M8xT8fHvDG+MkujSX2tifQ6R kbIijIKlaj+trYpXyZ7r4h0vcT009EeG6EWQzWNh8grbzzit9cqZPj/NwhxIT8mn+oVt hgiuL4OFxmxVGLN0kjzXnwGMrRwS9PeDxsadI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=xfBUOybct5kYuaj8NbEZOsTMymRDYMJlajmlZa3ZSJXHiE2equLQQ0rK41Xwe3/5zY 6y1ORqSyo6WRqE/QKsvn5jmLhzssnVGXExKylRDbBlqR7vKdD7lQ3KDbKgCRnaBFewox wJD+8GTbgMQzuxqstBKM+Ec8E4R4cxK/5TtMM= Received: by 10.213.57.136 with SMTP id c8mr38593ebh.5.1273613214365; Tue, 11 May 2010 14:26:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.20.140 with HTTP; Tue, 11 May 2010 14:26:34 -0700 (PDT) From: ck Date: Tue, 11 May 2010 23:26:34 +0200 Message-ID: Subject: Unit Test Refactoring To: dev@abdera.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Hi guys, I would like to refactor and extend the Unit tests, as I think this would create a solid fundament for any major refactoring or addition of new features. This includes the following steps: - remove all occurences of "extends TestCase" an replace them with annotations if necessary - remove all occurences of "extends Assert" and replace them with static imports of assert* - fix ABDERA-102 (https://issues.apache.org/jira/browse/ABDERA-102) - remove Testsuites (don't see for what they are needed anymore?) - remove unnecessary try/catches (example http://svn.apache.org/viewvc/abdera/java/trunk/security/src/test/java/org/apache/abdera/test/security/filter/SecurityFilterTest.java?revision=723328&view=markup) - reorder Test classes where necessary so that their structure is analog to the source classes - add further tests - update test dependencies This means a lot of long patches with only minor functional changes. I already added some patches (https://issues.apache.org/jira/browse/ABDERA-102, http://www.mail-archive.com/dev@abdera.apache.org/msg00291.html), but most of them where not committed. Would be great if I could hear your opinion to this approach. regards ck