Return-Path: Delivered-To: apmail-abdera-dev-archive@www.apache.org Received: (qmail 93175 invoked from network); 14 Apr 2010 12:12:10 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 14 Apr 2010 12:12:10 -0000 Received: (qmail 47126 invoked by uid 500); 14 Apr 2010 12:12:10 -0000 Delivered-To: apmail-abdera-dev-archive@abdera.apache.org Received: (qmail 46971 invoked by uid 500); 14 Apr 2010 12:12:09 -0000 Mailing-List: contact dev-help@abdera.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@abdera.apache.org Delivered-To: mailing list dev@abdera.apache.org Received: (qmail 46808 invoked by uid 99); 14 Apr 2010 12:12:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Apr 2010 12:12:09 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of ch.ko123@googlemail.com designates 209.85.219.226 as permitted sender) Received: from [209.85.219.226] (HELO mail-ew0-f226.google.com) (209.85.219.226) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Apr 2010 12:12:02 +0000 Received: by ewy26 with SMTP id 26so22106ewy.3 for ; Wed, 14 Apr 2010 05:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:received :message-id:subject:to:content-type; bh=UmZ0Avd//cOgHXVMJn2GmQf0H6ZDJKrXpyQdXakLikE=; b=XJSon0jczecfeBhmfvpMIp55XvTv7x28WpUAegmXf8mCdsFU5W0zFtLCIEUu6L6GxJ gtlV/EPRd+EMqAVxoYkN8FIdGUF7acw4t51oSiXqbIdzWxwYMmOKqWs4aGp+fwzeiHp6 274thQOZpv2yRNmpcxO2oPcy/kjSb5f1lqjBo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=LeCUpAn0K4AoWEftXfwBjye/vdQtMyKmb+I68k2m29cbrQ80BGQc36fpZg8d+CRV1y 1kKbEtGlhBlcayKn1H3524nzJ8nPGHptqSxB05SvsmY94iXkZ28mXPPGCirt2844O0o2 WMz1xBL4/TTwKgHEz/nL74uEjU3OmQRBV66Vc= MIME-Version: 1.0 Received: by 10.213.21.209 with HTTP; Wed, 14 Apr 2010 05:11:22 -0700 (PDT) From: ck Date: Wed, 14 Apr 2010 14:11:22 +0200 Received: by 10.213.68.141 with SMTP id v13mr3955973ebi.84.1271247102213; Wed, 14 Apr 2010 05:11:42 -0700 (PDT) Message-ID: Subject: [Patch] fix for broken test org.apache.abdera.test.security.filter.SecurityFilterTest To: dev@abdera.apache.org Content-Type: multipart/mixed; boundary=00c09f76b5f8f301b404843147f2 X-Virus-Checked: Checked by ClamAV on apache.org --00c09f76b5f8f301b404843147f2 Content-Type: text/plain; charset=ISO-8859-1 Hi, this patch is a revert of changes from revision 771450 (http://svn.apache.org/viewvc/abdera/java/trunk/server/src/main/java/org/apache/abdera/protocol/server/servlet/AbderaServlet.java?r1=771450&r2=771449&pathrev=771450). The intention of this commit was to avoid buffering of data according to https://issues.apache.org/jira/browse/ABDERA-210. But the side effect was, that that messages were not be signed any longer by the SignedResponseFilter as none of the writeTo methods in SigningResponseContextWrapper where called anymore, what leads to the failing unit test. As the Unit Test Code Coverage is not so great overall, i'm wondering if this might have had other side effects, too. So my suggestion is to revert this changes, reopen ABDERA-210, extend unit tests and come up with some different approach. regards ck --00c09f76b5f8f301b404843147f2 Content-Type: text/x-patch; charset=US-ASCII; name="abderaservlet.patch" Content-Disposition: attachment; filename="abderaservlet.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g803aqfc0 SW5kZXg6IHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYWJkZXJhL3Byb3RvY29sL3Nl cnZlci9zZXJ2bGV0L0FiZGVyYVNlcnZsZXQuamF2YQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzZXJ2ZXIvc3Jj L21haW4vamF2YS9vcmcvYXBhY2hlL2FiZGVyYS9wcm90b2NvbC9zZXJ2ZXIvc2VydmxldC9BYmRl cmFTZXJ2bGV0LmphdmEJKFJldmlzaW9uIDkzMjg1NCkKKysrIHNlcnZlci9zcmMvbWFpbi9qYXZh L29yZy9hcGFjaGUvYWJkZXJhL3Byb3RvY29sL3NlcnZlci9zZXJ2bGV0L0FiZGVyYVNlcnZsZXQu amF2YQkoQXJiZWl0c2tvcGllKQpAQCAtMTI1LDExICsxMjUsNyBAQAogICAgICAgICB9CiAgICAg ICB9CiAgICAgICBpZiAoIXJlcXVlc3QuZ2V0TWV0aG9kKCkuZXF1YWxzKCJIRUFEIikgJiYgY29u dGV4dC5oYXNFbnRpdHkoKSkgewotICAgICAgICBpZiAoY29udGV4dC5pc0JpbmFyeSgpKSB7CiAg ICAgICAgICAgY29udGV4dC53cml0ZVRvKHJlc3BvbnNlLmdldE91dHB1dFN0cmVhbSgpKTsKLSAg ICAgICAgfSBlbHNlIHsKLSAgICAgICAgICBjb250ZXh0LndyaXRlVG8ocmVzcG9uc2UuZ2V0V3Jp dGVyKCkpOwotICAgICAgICB9CiAgICAgICB9ICAKICAgICB9IGVsc2UgewogICAgICAgZXJyb3Io IkludGVybmFsIFNlcnZlciBFcnJvciIsIG51bGwsIHJlc3BvbnNlKTsK --00c09f76b5f8f301b404843147f2--