abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ck <ch.ko...@googlemail.com>
Subject [Patch] fix for broken test org.apache.abdera.test.security.filter.SecurityFilterTest
Date Wed, 14 Apr 2010 12:11:22 GMT
Hi,

this patch is a revert of changes from revision 771450
(http://svn.apache.org/viewvc/abdera/java/trunk/server/src/main/java/org/apache/abdera/protocol/server/servlet/AbderaServlet.java?r1=771450&r2=771449&pathrev=771450).
The intention of this commit was to avoid buffering of data according
to https://issues.apache.org/jira/browse/ABDERA-210. But the side
effect was, that that messages were not be signed any longer by the
SignedResponseFilter as none of the writeTo methods in
SigningResponseContextWrapper where called anymore, what leads to the
failing unit test.
As the Unit Test Code Coverage is not so great overall, i'm wondering
if this might have had other side effects, too. So my suggestion is to
revert this changes, reopen ABDERA-210, extend unit tests and come up
with some different approach.

regards

ck

Mime
View raw message