abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jon Hewitt (JIRA)" <j...@apache.org>
Subject [jira] Created: (ABDERA-231) NullPointerException in RequestOptions.addHeader() when no previous header with that name has been set
Date Fri, 08 May 2009 12:53:45 GMT
NullPointerException in RequestOptions.addHeader() when no previous header with that name has
been set
------------------------------------------------------------------------------------------------------

                 Key: ABDERA-231
                 URL: https://issues.apache.org/jira/browse/ABDERA-231
             Project: Abdera
          Issue Type: Bug
    Affects Versions: 0.4.0
         Environment: All
            Reporter: Jon Hewitt


This code snippet recreates the problem.
        RequestOptions requestOptions = client.getDefaultRequestOptions();
	requestOptions.addHeader("Cookie", "anyNonNullValue");

Caused by: java.lang.NullPointerException
	at java.util.Arrays$ArrayList.<init>(Arrays.java:2370)
	at java.util.Arrays.asList(Arrays.java:2356)
	at org.apache.abdera.protocol.client.RequestOptions.addHeader(RequestOptions.java:272)
	at org.apache.abdera.protocol.client.RequestOptions.addHeader(RequestOptions.java:263)

It looks like that RequestOptions.addEncodedHeader() also has the same problem of calling
Arrays.asList() before checking for returned null value from getHeaders().get(header)

One can workaround the problem by calling getHeader() to see if the header has previous values.
 If it doesn't, just call setHeader().

This is a regression - addHeader() works fine in 0.2.2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message