Mailing-List: contact abdera-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: abdera-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of david.primmer@gmail.com
 designates 209.85.198.250 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=Pw0oATFXsKLWioPMmXBWn1IjRGbedyTr7fFnMUC8KpxtlkRjWe69JqKuRQu6beP8ls
         dBAohI9MPSGFNYiWGswdHLQCgk/W2ffmaqFjsNfeXBBAoH9Z0USKIN2JR19c6gyUbXRQ
         wgaUDa+TDxyVUpXBFsw9UwAAAnLETK92j8cHE=
Message-ID: <ce54216b0807041407y17b1ca0fv82d3bb736efe8a29@mail.gmail.com>
Date: Fri, 4 Jul 2008 14:07:52 -0700
From: "David Primmer" <david.primmer@gmail.com>
To: abdera-dev@incubator.apache.org
Subject: Re: Refactoring AbstractProvider to make it open for extension
In-Reply-To: <806e13040807041351u7316b09kb616bd2bc76b7193@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <806e13040807041043xd466a7x899a6092d1d0408e@mail.gmail.com>
	 <ce54216b0807041153v2d0d1edaldca172182a5a4ea4@mail.gmail.com>
	 <806e13040807041351u7316b09kb616bd2bc76b7193@mail.gmail.com>

On Fri, Jul 4, 2008 at 1:51 PM, Sergio Bossa <sergio.bossa@gmail.com> wrote:
> On Fri, Jul 4, 2008 at 8:53 PM, David Primmer <david.primmer@gmail.com> wrote:
>
>> I'm not sure what things you want to do with the request processing
>> that force you to replace the 'if' statements that you mention.
>> [CUT]
>
> AbstractProvider uses "if" statements in order to decide what to do
> depending on the TargetType: this prevents you to extend provider
> features for supporting new target types, i.e. Open Search documents.
> I know you can support OpenSearch (or whatever else) with filters,
> resolvers, and alike, but I think it would be wrong: if it's the
> provider job to decide what to do depending on the TargetType, you
> shouldn't give this same responsibility to other classes.

Ah, I see what you mean. I guess I just never thought of this as a new
TargetType, but rather a new adapter. For example, I recently wanted
to add Json processing and avoid using the FOM, so I thought a
JSONCollection TargetType might work. But then I realized that I could
just re-use collection TargeType and make a JSON CollectionAdapter.
Having more easily extensible TargetType system would make abdera more
general purpose. I suppose it's useful for doing things that aren't
exactly resource oriented, like processing a call for a service doc.
Shindig could extend TargetType to include processing our Discovery
Doc which is a more dynamic Service Doc.

davep

>
> Obviously IMHO.
> Cheers,
>
> Sergio B.
>
> --
> Sergio Bossa
> Software Passionate, Java Technologies Specialist and Open Source Enthusiast.
> Blog : http://sbtourist.blogspot.com
> Sourcesense - making sense of Open Source : http://www.sourcesense.com
> Pro-netics s.p.a. : http://www.pronetics.it
>