Mailing-List: contact abdera-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: abdera-dev@incubator.apache.org
Message-ID: <1706259656.1216407391945.JavaMail.jira@brutus>
Date: Fri, 18 Jul 2008 11:56:31 -0700 (PDT)
From: "David Primmer (JIRA)" <jira@apache.org>
To: abdera-dev@incubator.apache.org
Subject: [jira] Commented: (ABDERA-188) OpenSearch support improvement
In-Reply-To: <951169244.1215531392047.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614840#action_12614840 ] 

David Primmer commented on ABDERA-188:
--------------------------------------

Moves and are notoriously hard to do with patches and svn. 

I just tried to apply the v3 diff and there are still problems.

You have modify diffs for newly created resources:
one example is
Index: src/main/java/org/apache/abdera/ext/opensearch/model/IntegerElement.java

another baffler is
--- src/test/resources/atomResponse.xml	(revision 676829)
which I think david c complained about earlier.

You'll need to fix these things up. I suggest you verify that your patches work by applying them to a newly checked out wc before submitting them. You'll find these don't work. I suspect the problem is that your diffs do not span the proper revision range.

davep

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, opensearchV2.zip, OpenSearchV3.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.