abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ABDERA-190) [core] serialization and concurrency updates to AbstractListParseFilter and AbstractParseFilter
Date Wed, 30 Jul 2008 03:11:31 GMT

    [ https://issues.apache.org/jira/browse/ABDERA-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618048#action_12618048

Nathan Beyer commented on ABDERA-190:

With regard to the open concurrency question, perhaps the opposite should be considered. Make
the class AbstractListParseFilter NOT thread-safe and leave the concurrency protection up
to higher constructs.

> [core] serialization and concurrency updates to AbstractListParseFilter and AbstractParseFilter
> -----------------------------------------------------------------------------------------------
>                 Key: ABDERA-190
>                 URL: https://issues.apache.org/jira/browse/ABDERA-190
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Nathan Beyer
>         Attachments: ABDERA-190.patch
> There are currently some weaknesses in the serialization and concurrency facets of the
AbstractListParseFilter and AbstractParseFilter.
> Serialization adjustments
> * declare explicit serialVersionUID fields
> * make Collection-based fields transient and implement custom read/write methods
> Concurrency adjustments
> * remove the Collections.synchronizedXXX types
> * use synchronized blocks to wrap all access to the fields; this will increase the atomicity
to the complete interactions with the fields, instead just each method call
> Open questions
> * since AbstractListParseFilter adds thread-safety, should the AbstractParseFilter also
be thread-safe (the 'toggle' method's not safe because it's not atomic)

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message