Mailing-List: contact abdera-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: abdera-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of jasnell@gmail.com designates
 66.249.82.227 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding;
        b=K3jFz9r6dJjvsOFmz9ez1w1yQ9TUuuAznW2Ucs1EFzfnP2H7aM2GCzf2CkGOK8l2PZ75vA2GjY3VmDt3tg9y86twxTX3J6c2H80T+VRslWswt8kRr1DFOvHDKBpP4VMP7rV32dtoMGULsjDJIamxv9QROktlz3Fr0a/m7oKzbEw=
Message-ID: <482AFCA2.7080102@gmail.com>
Date: Wed, 14 May 2008 07:52:18 -0700
From: James M Snell <jasnell@gmail.com>
User-Agent: Thunderbird 2.0.0.14 (X11/20080505)
MIME-Version: 1.0
To: abdera-dev@incubator.apache.org
Subject: Re: Passing an Object from the servlet through to the provider?
References: <482A5EE6.4000808@wso2.com> <482A7BCF.9080108@gmail.com>
 <482AF3CD.8010907@wso2.com>
In-Reply-To: <482AF3CD.8010907@wso2.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Glen Daniels wrote:
> Hi James!
> 
> James M Snell wrote:
>> RequestContext.setAttribute(Scope scope, String name, Object value) 
>> ... where Scope == Scope.REQUEST or Scope.SESSION
>>
>> Does that work for what you need?
> 
> Nope, because that implies you have access to the RequestContext, which 
> I don't.  Even if I subclass AbderaServlet, there's no hook in service() 
> that lets me get at the ServletRequestContext in between creation and 
> passing it to the Provider/TargetResolver.
> 

You can create a Filter.  The filters are invoked immediately before the 
Provider.  I've used them to set properties on the RequestContext prior 
to passing it off to the Provider for handling.

> To be clear, here's my situation:
> 
> class Servlet1 {
>   init() {
>     Object thing = createObject(); // Here's my thing
>     servletContext.setAttribute("thing", thing);  // Store it somewhere
>   }
> }
> 
> class MyServlet extends AbderaServlet {
>   service(request, response) {
>     // I can't get at the ServletContext from within Abdera, so...
>     Object thing = servletContext.getAttribute("thing");
>     // ...put it somewhere I *can* get to
>     request.setAttribute("thing", thing);
>     super.service(request, response);
>   }
> }
> 
> If AbderaServlet made the ServletContext available in the same way it 
> makes the HttpServletRequest available, I wouldn't need the subclassed 
> servlet or the per-request overhead.

True. Ok, I'll see what I can do... unless, of course, you want to 
submit a patch :-)

- James

> 
> --Glen
> 
>> Glen Daniels wrote:
>>> Hey Abderites:
>>>
>>> So here's my situation.  I've got an Abdera server (i.e. 
>>> AbderaServlet in Tomcat) running that needs to share some information 
>>> with another servlet.  In particular, the non-AbderaServlet (let's 
>>> call it Servlet1) needs to create an Object and then in an ideal 
>>> world pass that through to the AbderaServlet in such a way that the 
>>> Provider instance that gets created has access to it.  Make sense?
>>>
>>> The best solution for me would be to put something into the 
>>> ServletContext, and then somehow get access to that later - but I 
>>> can't seem to do that currently.
>>>
>>> Since the initialization step doesn't really need to be done until 
>>> the first actual request, and I've already got a solid connection 
>>> between my Provider and my TargetResolver, I figured one way would be 
>>> something like (pseudocode):
>>>
>>> TargetResolver.resolve(Request request) {
>>>   ServletRequestContext context = (ServletRequestContext)request;
>>>   if (thing == null) {
>>>     thing = context.getServletContext().getAttribute("thing");
>>>   }
>>> }
>>>
>>> A patch that would just carry the ServletContext in addition to the 
>>> HttpServletRequest in each ServletRequestContext would be very easy 
>>> to do in Abdera, and would get me what I need.  Am happy to 
>>> contribute same.
>>>
>>> Is there a better way to do this?  I noticed the ManagedProvider 
>>> stuff but it looks like you can only pass Strings in there, and only 
>>> in very specific ways.  Perhaps some kind of more general 
>>> initialization context that I'm missing?  The above patch would solve 
>>> my problem later but not in v0.4.0.
>>>
>>> The solution I've come up with for now is to subclass the 
>>> AbderaServlet, and add the ServletContext to every HttpRequest as an 
>>> attribute - that lets me do basically the same trick, but it seems... 
>>> less than optimal.
>>>
>>> Thoughts/comments?
>>>
>>> Thanks,
>>> --Glen
>>>
>>
>