abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefano Linguerri (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ABDERA-167) DefaultWorkspaceManager.getCollectionAdapter(RequestContext request) doesn't return CollectionAdapter
Date Wed, 28 May 2008 12:35:46 GMT

    [ https://issues.apache.org/jira/browse/ABDERA-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600455#action_12600455
] 

Stefano Linguerri commented on ABDERA-167:
------------------------------------------

DefaultWorkspaceManager:
My abdera servlet is configured for /atom/*

   Method:
      public CollectionAdapter getCollectionAdapter(RequestContext request) {

First line of method

the code of 0.4.0:
   String path = request.getTargetBasePath() + request.getTargetPath();

assigns to path value:
   /fooContext/atom/atom/myfeed (atom repeated twice). 

So when in the method DefaultWorkspaceManager.getCollectionAdapter() path is used in: 
...
if (path.equals(href) ||
          (href != null && 
           path.startsWith(href) &&
           URI_GEN_DELIMS.contains(path.substring(href.length(), href.length() + 1)))) { 
  
...
this always returns false because href has value  /fooContext/atom/myfeed

the code of 0.5.0 
   String path = request.getContextPath() + request.getTargetPath();

assigns to path value:
   /fooContext/atom/myfeed (this is correct)

anyway the 0.5.0 and trunk was fixed. 
see:
http://mail-archives.apache.org/mod_mbox/incubator-abdera-commits/200804.mbox/%3C20080430002017.10C0C23889F8@eris.apache.org%3E


> DefaultWorkspaceManager.getCollectionAdapter(RequestContext request) doesn't return CollectionAdapter
> -----------------------------------------------------------------------------------------------------
>
>                 Key: ABDERA-167
>                 URL: https://issues.apache.org/jira/browse/ABDERA-167
>             Project: Abdera
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Stefano Linguerri
>
> the method DefaultWorkspaceManager.getCollectionAdapter(RequestContext request) doesn't
return CollectionAdapter.
> eg: if a CollectionAdapter is cofigured for /fooContext/atom/myfeed is matched with /fooContext/atom/atom/myfeed
(atom  repeted twice).
> The source and binary distribution of 0.4.0 have this bug. 
> The trunk was patched Wed, 30 Apr 2008 00:20:16 GMT (see: http://mail-archives.apache.org/mod_mbox/incubator-abdera-commits/200804.mbox/%3C20080430002017.10C0C23889F8@eris.apache.org%3E)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message