Mailing-List: contact abdera-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: abdera-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of jasnell@gmail.com designates
 209.85.132.243 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding;
        b=EP0QpWQIUywZle4oBgKzSICIP6vFckEnK/1fDshH6f2ABl8VEU+YkSDxD1d13TAsLnarD3taBIhk6ZWAsgs4AXtpgBLYwJgv9TUeDww8d2y1LlodYvff06IzaalHPN+8d6NgkEypKzlYyjqh5ar2yMJ0XYn43r4NtgeVMa1nTok=
Message-ID: <48175DAF.60207@gmail.com>
Date: Tue, 29 Apr 2008 10:41:03 -0700
From: James M Snell <jasnell@gmail.com>
User-Agent: Thunderbird 2.0.0.12 (X11/20080227)
MIME-Version: 1.0
To: abdera-dev@incubator.apache.org
Subject: Re: [jira] Commented: (ABDERA-146) Bad entry edit link created in
 my server when using a provider base path
References: <1562250313.1208230264773.JavaMail.jira@brutus>
	 <1285805819.1208268424991.JavaMail.jira@brutus>
 <ce54216b0804291016q6bc429fgf7072673a3b109f0@mail.gmail.com>
In-Reply-To: <ce54216b0804291016q6bc429fgf7072673a3b109f0@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

I likely won't be able to get to this (or the other issues in jira) 
until at least the end of this week.  I'll be able to let you know my 
thoughts then.

- James

David Primmer wrote:
> Any comment on this going into .4? It is a bad breakage of routes. If
> .4 is not possible, then possibly a snapshot pushed up here:
> http://people.apache.org/repo/m2-snapshot-repository
> 
> thanks.
> 
> davep
> 
> On Tue, Apr 15, 2008 at 7:07 AM, Remy Gendron (JIRA) <jira@apache.org> wrote:
>>     [ https://issues.apache.org/jira/browse/ABDERA-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589091#action_12589091 ]
>>
>>  Remy Gendron commented on ABDERA-146:
>>  -------------------------------------
>>
>>  David, your fix is OK I think for the RouteManager itself.
>>
>>  However, there was still an issue in the DefaultWorkspaceManager. Following the fix in the RouteManager, the workspace could no longer find the requested adapter as now the two paths would not match.
>>
>>  I am proposing a patch for the DefaultWorkspaceManager. With it, all of my unit tests are green in the four combinations of root servlet path/specific servlet path and root application context/specific application context.
>>
>>  I think this needs to be included in the 0.4.0 branch if it is to become an RC1.
>>
>>  Thanks again David.
>>
>>  > Bad entry edit link created in my server when using a provider base path
>>  > ------------------------------------------------------------------------
>>  >
>>  >                 Key: ABDERA-146
>>  >                 URL: https://issues.apache.org/jira/browse/ABDERA-146
>>  >             Project: Abdera
>>  >          Issue Type: Bug
>>  >    Affects Versions: 0.4.0
>>  >            Reporter: Remy Gendron
>>  >         Attachments: route_manager.patch
>>  >
>>  >
>>  > My Abdera servlet is not mapped to the root of my application context. It is mapped to /atom/*, so that my application context can host multiple servlets and a static HTML site at the root path.
>>  > Thus, I create my provider with a base of /atom/. This in turn creates the following route: /atom/:collection/:entry
>>  > When I GET an entry, the resolving part goes well. However, the generated edit link for this entry duplicates the base part of the URI.
>>  > RouteManager.urlFor(RequestContext, Object, Object) line: 158
>>  > SpringProvider(AbstractProvider).urlFor(RequestContext, Object, Object) line: 102
>>  > ServletRequestContext(AbstractRequestContext).urlFor(Object, Object) line: 184
>>  > MovieAdapter(AbstractCollectionAdapter).getHref(RequestContext) line: 82
>>  > MovieAdapter(AbstractEntityCollectionAdapter<T>).getFeedIriForEntry(T, RequestContext) line: 548
>>  > MovieAdapter(AbstractEntityCollectionAdapter<T>).getEntryFromCollectionProvider(RequestContext) line: 721
>>  > MovieAdapter(AbstractEntityCollectionAdapter<T>).getEntry(RequestContext) line: 316
>>  > SpringProvider(AbstractProvider).process(RequestContext) line: 155
>>  > The last stack frame (urlFor) is where I believe the error is. The route expands properly and includes the provider base path. However, the getTargetBasePath() call concatenates the application context with the servlet path, the servlet path being equal to the provider base path.
>>  > Real values used in my tests:
>>  > application context: /imdb
>>  > provider base: /atom/
>>  > adapter href: movies
>>  > GET URI: http://localhost:8080/imdb/atom/movies/12345
>>  > The generated edit URI is: http://localhost:8080/imdb/atom/atom/movies/12345
>>  > Thanks for looking into this.
>>  > Remy
>>
>>  --
>>  This message is automatically generated by JIRA.
>>  -
>>  You can reply to this email to add a comment to the issue online.
>>
>>
>